Bug 494503 - Review Request: hyphen-sa - Sanskrit hyphenation rules
Summary: Review Request: hyphen-sa - Sanskrit hyphenation rules
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-07 08:17 UTC by Caolan McNamara
Modified: 2009-04-08 08:06 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-04-08 08:06:29 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Caolan McNamara 2009-04-07 08:17:06 UTC
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-sa.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-sa-0.20081010-1.fc10.src.rpm
Description: Sanskrit hyphenation rules (also usable for Bengali)

Comment 1 Parag AN(पराग) 2009-04-07 09:00:06 UTC
I think if hyphen-bn subpackage added to hyphen-sa then we can list that in comps under bengali-support language group

Comment 2 Caolan McNamara 2009-04-07 09:35:05 UTC
The package provides hyphen-bn at the moment, so you should be able to do that already, i.e.

rpm -qp --provides hyphen-sa-0.20081010-1.fc10.noarch.rpm |grep hyphen-bn
hyphen-bn = 0.20081010-1.fc10

The (small) catch to making a physical subpackage called hyphen-bn is that it will contain only a link to hyph_sa_IN.dic (and have a Requires: on hyphen-sa) and then rpmlink will complain about dangling links.

Comment 3 Parag AN(पराग) 2009-04-07 11:06:05 UTC
Thanks for the above info.

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1281841
+ rpmlint output for SRPM and for RPM is silent.
+ source files match upstream.
b34adf4185eb8f46773627c240b24806  hyph-sa.tex
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.

Comment 4 Caolan McNamara 2009-04-07 11:54:52 UTC
New Package CVS Request
=======================
Package Name: hyphen-sa
Short Description: Sanskrit hyphenation rules
Owners: caolanm
Branches: F-11, devel
InitialCC:

Comment 5 Kevin Fenzi 2009-04-08 02:53:03 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.