Bug 494503 - Review Request: hyphen-sa - Sanskrit hyphenation rules
Review Request: hyphen-sa - Sanskrit hyphenation rules
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-07 04:17 EDT by Caolan McNamara
Modified: 2009-04-08 04:06 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-04-08 04:06:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Caolan McNamara 2009-04-07 04:17:06 EDT
Spec URL: http://people.redhat.com/caolanm/rpms/hyphen-sa.spec
SRPM URL: http://people.redhat.com/caolanm/rpms/hyphen-sa-0.20081010-1.fc10.src.rpm
Description: Sanskrit hyphenation rules (also usable for Bengali)
Comment 1 Parag AN(पराग) 2009-04-07 05:00:06 EDT
I think if hyphen-bn subpackage added to hyphen-sa then we can list that in comps under bengali-support language group
Comment 2 Caolan McNamara 2009-04-07 05:35:05 EDT
The package provides hyphen-bn at the moment, so you should be able to do that already, i.e.

rpm -qp --provides hyphen-sa-0.20081010-1.fc10.noarch.rpm |grep hyphen-bn
hyphen-bn = 0.20081010-1.fc10

The (small) catch to making a physical subpackage called hyphen-bn is that it will contain only a link to hyph_sa_IN.dic (and have a Requires: on hyphen-sa) and then rpmlink will complain about dangling links.
Comment 3 Parag AN(पराग) 2009-04-07 07:06:05 EDT
Thanks for the above info.

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1281841
+ rpmlint output for SRPM and for RPM is silent.
+ source files match upstream.
b34adf4185eb8f46773627c240b24806  hyph-sa.tex
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.
Comment 4 Caolan McNamara 2009-04-07 07:54:52 EDT
New Package CVS Request
=======================
Package Name: hyphen-sa
Short Description: Sanskrit hyphenation rules
Owners: caolanm
Branches: F-11, devel
InitialCC:
Comment 5 Kevin Fenzi 2009-04-07 22:53:03 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.