Spec URL: http://ramakrishnareddy.info/fedora/python-achoo.spec SRPM URL: http://ramakrishnareddy.info/fedora/python-achoo-1.0-1.fc11.src.rpm Description: Achoo is a fluent interface for unit testing Python objects. Achoo makes it easy to make assertions about the properties and behaviours of Python objects. For example, is this object equal to this other one? Does calling this function with these arguments raise an error? More Infomation on fluent from here http://www.martinfowler.com/bliki/FluentInterface.html
1)unable to verify sources. 2030a24b9daa0232aa776c08461e8061 achoo-1.0.tar.gz <= from upstream 00bcb086f715c41821d22748d123308c achoo-1.0.tar.gz <= from SRPM Please add correct upstream sources while building SRPM. submit new SRPM with adding Changelog and increasing release to -2 Changelog should add like "Add correct upstream source"
1. Added the correct Source file. * http://ramakrishnareddy.info/fedora/python-achoo-1.0-2.fc10.src.rpm 2. Updated the SPEC file with the changelog entries * http://ramakrishnareddy.info/fedora/python-achoo.spec
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1299561 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 2030a24b9daa0232aa776c08461e8061 achoo-1.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: python-achoo Short Description: A fluent interface for testing Python Object Owners: ramkrsna Branches: F-10 F-11 InitialCC:
cvs done.