Bug 495436 (perl-File-Pid) - Review Request: perl-File-Pid - Pid File Manipulation
Summary: Review Request: perl-File-Pid - Pid File Manipulation
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-File-Pid
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/File-Pid/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-13 06:56 UTC by Iain Arnell
Modified: 2016-08-14 17:16 UTC (History)
3 users (show)

Fixed In Version: 1.01-1.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-14 14:43:50 UTC
Type: ---
Embargoed:
panemade: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Iain Arnell 2009-04-13 06:56:36 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-File-Pid.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-File-Pid-1.01-1.fc11.src.rpm

Description:
This software manages a pid file for you. It will create a pid file,
query the process within to discover if it's still running, and remove
the pid file.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1293567

*rt-0.05

Comment 1 Parag AN(पराग) 2009-04-13 07:27:05 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1293567
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d927b40215cbfbff233d9feb53529532  File-Pid-1.01.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=10,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.02 cusr  0.02 csys =  0.06 CPU)
+ Package perl-File-Pid-1.01-1.fc11.noarch =>
  Provides: perl(File::Pid) = 1.1
  Requires: perl(File::Basename) perl(File::Spec::Functions) perl(base) perl(strict) perl(vars)

APPROVED.

Comment 2 Iain Arnell 2009-04-13 07:54:28 UTC
New Package CVS Request
=======================
Package Name: perl-File-Pid
Short Description: Pid File Manipulation
Owners: iarnell
Branches: F-10
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-04-13 15:52:30 UTC
cvs done.

Comment 4 Iain Arnell 2009-04-14 03:51:15 UTC
Looks like something went wrong with cvs setup - no branch directories appear to have been created.

Comment 5 Kevin Fenzi 2009-04-14 04:58:55 UTC
Try now?

Comment 6 Fedora Update System 2009-04-14 14:43:02 UTC
perl-File-Pid-1.01-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-File-Pid-1.01-1.fc10

Comment 7 Fedora Update System 2009-04-27 21:31:01 UTC
perl-File-Pid-1.01-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Iain Arnell 2010-02-27 11:37:23 UTC
Package Change Request
======================
Package Name: perl-File-Pid
New Branches: EL-4 EL-5
Owners: iarnell
InitialCC: perl-sig

Comment 9 Jason Tibbitts 2010-02-28 22:29:20 UTC
CVS done.

Comment 10 Fedora Update System 2010-03-01 04:13:53 UTC
perl-File-Pid-1.01-3.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/perl-File-Pid-1.01-3.el5

Comment 11 Fedora Update System 2010-03-01 04:13:59 UTC
perl-File-Pid-1.01-3.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/perl-File-Pid-1.01-3.el4

Comment 12 Fedora Update System 2010-03-18 22:37:18 UTC
perl-File-Pid-1.01-3.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-03-18 22:37:26 UTC
perl-File-Pid-1.01-3.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.