Red Hat Bugzilla – Bug 495604
Old backup files are not removed when backup mode is ssh
Last modified: 2009-07-28 14:48:34 EDT
Description of problem:
Backup files accumulate in the destination backup directory without end.
Version-Release number of selected component (if applicable):
1.43.3rc1, but this is what I picked up today after the OS update. I noticed this problem weeks ago when I was running the previous version of fwbackups.
Steps to Reproduce:
1. Create a backup set with destination type set to SSH (in the Destination tab)
2. In 'Options (simple)' tab set "Number of old backups to keep" to some number, 2 for example
3. Start the backup manually several times (more than 2), by clicking on "Backup Set Now" button in the main window
Backup files accumulate in the destination directory. No backup files are ever removed.
After reaching the limit, old backup file should be deleted.
It appears that when the destination type is "Local folder" the purging of old backup files works correctly.
On glancing the code (backend.py), in function RemoveOldBackups, it seems that in the beginning the function gathers a list of files from the current directory (which seems to be /tmp) and then it works on that list in order to decide which files are ripe for purging. But the backup files are not in /tmp, they are somewhere across the network ...
Thanks for reporting this. The 1.43.3 release is focusing mainly on improving remote (ssh) support, so I'll try to get this fixed for 1.43.3rc2.
fwbackups-1.43.3-0.3.rc2.fc11 has been submitted as an update for Fedora 11.
This message is a reminder that Fedora 9 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 9. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '9'.
Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 9's end of life.
Bug Reporter: Thank you for reporting this issue and we are sorry that
we may not be able to fix it before Fedora 9 is end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora please change the 'version' of this
bug to the applicable version. If you are unable to change the version,
please add a comment here and someone will do it for you.
Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.
The process we are following is described here:
fwbackups-1.43.3-0.3.rc2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update fwbackups'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-6096
I don't have time to upgrade my desktop at work to F11 now (I know I should). Without an rpm for F9 I can not test it.
A F9 update is pending now: https://admin.fedoraproject.org/updates/fwbackups-1.43.3-0.2.rc2.fc9
fwbackups-1.43.3-0.3.rc2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
fwbackups-1.43.3-0.3.rc2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Fix confirmed. Version 1.43.3rc2 on Fedora 9 works fine now. Thanks!