Spec URL: http://www.declera.com/~yaneti/perl-POE-Filter-Transparent-SMTP/perl-POE-Filter-Transparent-SMTP.spec SRPM URL: http://www.declera.com/~yaneti/perl-POE-Filter-Transparent-SMTP/perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm Description: POE data filter which aims to make SMTP data transparent just before going onto the wire as per RFC 821 Section 4.5.2.
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1301504
is yaneti sponsored in packager group? I did search in packager for submitter but didn't find any information.
I note that the LICENSE file is executable; please remove this bit before importing/building. (Note also the rpmlint warning on it.) Other than that, looks good. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1301504 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 4e4f596fdd81d0c85f6f7359281903b4446b7f80 POE-Filter-Transparent-SMTP-0.2.tar.gz 4e4f596fdd81d0c85f6f7359281903b4446b7f80 POE-Filter-Transparent-SMTP-0.2.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm ====> requires for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.src.rpm perl(POE) perl(Test::Pod) perl(Test::Pod::Coverage) =====> perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.noarch.rpm <===== ====> rpmlint perl-POE-Filter-Transparent-SMTP.noarch: W: spurious-executable-perm /usr/share/doc/perl-POE-Filter-Transparent-SMTP-0.2/LICENSE 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ====> provides for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.noarch.rpm perl(POE::Filter::Transparent::SMTP) = 0.2 perl-POE-Filter-Transparent-SMTP = 0.2-1.fc10 ====> requires for perl-POE-Filter-Transparent-SMTP-0.2-1.fc10.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Data::Dumper) perl(POE::Filter::Line) perl(strict) perl(warnings) APPROVED (provided LICENSE is made non-executable)
(In reply to comment #2) > is yaneti sponsored in packager group? I did search in packager for submitter > but didn't find any information. Erm... good question. Yanko, are you sponsored?
When I checked yaneti username on IRC with zodbot I see not a single approved group for this user. He need to first get approved for cla_done and cla_fedora.
(In reply to comment #4) > (In reply to comment #2) > > is yaneti sponsored in packager group? I did search in packager for submitter > > but didn't find any information. > > Erm... good question. Yanko, are you sponsored? Nope, sorry. This review submission as well as my recent others were more for "documentation" purposes. I happen to need rpms of these for work related reasons and now that I made them I might as well post them somewhere. The package review queue is the place I personally check first if something is not already packaged, so it seems like a good place to put these. I'll be happy if someone jumps in to maintain them...
fixed LICENSE permissions http://www.declera.com/~yaneti/perl-POE-Filter-Transparent-SMTP/perl-POE-Filter-Transparent-SMTP-0.2-2.fc10.src.rpm
(In reply to comment #6) > (In reply to comment #4) > > Erm... good question. Yanko, are you sponsored? > > Nope, sorry. This review submission as well as my recent others were more for > "documentation" purposes. I happen to need rpms of these for work related > reasons and now that I made them I might as well post them somewhere. The > package review queue is the place I personally check first if something is not > already packaged, so it seems like a good place to put these. I'll be happy if > someone jumps in to maintain them... Do you want to be sponsored? If so, I'll take a look through your other submissions and if things look good, we can work on that...
(In reply to comment #8) > (In reply to comment #6) > > (In reply to comment #4) > > > Erm... good question. Yanko, are you sponsored? > > > > Nope, sorry. This review submission as well as my recent others were more for > > "documentation" purposes. I happen to need rpms of these for work related > > reasons and now that I made them I might as well post them somewhere. The > > package review queue is the place I personally check first if something is not > > already packaged, so it seems like a good place to put these. I'll be happy if > > someone jumps in to maintain them... > > Do you want to be sponsored? If so, I'll take a look through your other > submissions and if things look good, we can work on that... Ok. Let's try that. I've massaged my other submissions (listed below) and...ahem.. completed the CLA. bug 495888 perl-POE-Component-Log4perl bug 495885 perl-POE-Component-Client-SMTP (depends on this one) bug 494986 mysqludf_xql Thanks
Chris, are you going to sponsor Yanko?
Removing NEEDSPONSOR. Yanko, now you can make CVS request for this package.
New Package CVS Request ======================= Package Name: perl-POE-Filter-Transparent-SMTP Short Description: A POE filter for SMTP Owners: yaneti Branches: F-10 F-11 InitialCC: perl-sig
CVS done.
Thanks for the review.