Bug 495925 - Review Request: pyxmlsec - Python bindings for the XML Security Library
Review Request: pyxmlsec - Python bindings for the XML Security Library
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Marek Mahut
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-15 11:25 EDT by Lubomir Rintel
Modified: 2009-04-16 01:39 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-04-16 01:39:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmahut: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2009-04-15 11:25:47 EDT
SPEC: http://v3.sk/~lkundrak/SPECS/pyxmlsec.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/pyxmlsec-0.3.0-1.fc11.src.rpm

Description:

PyXMLSec is a set of Python bindings for the XML Security Library, a C
library based on LibXML2. The library supports major XML security standards
including, XML Signature, XML Encryption, Canonical XML and Exclusive
Canonical XML.
Comment 1 Lubomir Rintel 2009-04-15 11:27:11 EDT
Builds fine in el5 mock.
Rpmlint has one warning, which can be safely ignored:

pyxmlsec.i586: E: non-executable-script /usr/lib/python2.6/site-packages/xmlsec.py 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

It's not executable and not meant to be executable. Shebang there is therefore just a comment, and thus I'm not going to patch it away.
Comment 2 Marek Mahut 2009-04-15 12:05:49 EDT
Liar, liar, pants on fire!

+ iconv -f iso8859-1 -t utf8
/var/tmp/rpm-tmp.88790: line 42: /usr/share/doc/pyxmlsec-0.3.0/AUTHORS: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.88790 (%prep)

http://koji.fedoraproject.org/koji/taskinfo?taskID=1300546
Comment 3 Lubomir Rintel 2009-04-15 12:08:42 EDT
(In reply to comment #2)
> Liar, liar, pants on fire!
> 
> + iconv -f iso8859-1 -t utf8
> /var/tmp/rpm-tmp.88790: line 42: /usr/share/doc/pyxmlsec-0.3.0/AUTHORS: No such
> file or directory
> error: Bad exit status from /var/tmp/rpm-tmp.88790 (%prep)

Doh! I forgot to make the package BuildRequire itself!

SPEC: http://v3.sk/~lkundrak/SPECS/pyxmlsec.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/pyxmlsec-0.3.0-2.fc11.src.rpm
Comment 4 Marek Mahut 2009-04-15 13:34:18 EDT
Looks fine, approved.
Comment 5 Lubomir Rintel 2009-04-15 13:54:03 EDT
Danke schon Marek!

New Package CVS Request
=======================
Package Name: pyxmlsec
Short Description: Python bindings for the XML Security Library
Owners: lkundrak
Branches: EL-5 F-10
Comment 6 Kevin Fenzi 2009-04-16 00:35:55 EDT
I assume you want a F-11 branch here. 

cvs done with F-11 branch added.
Comment 7 Lubomir Rintel 2009-04-16 01:39:04 EDT
Imported and built.

Note You need to log in before you can comment on or make changes to this bug.