Spec URL: http://fedorapeople.org/~iarnell/review/perl-Getopt-ArgvFile.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Getopt-ArgvFile-1.11-1.fc11.src.rpm Description: This module simply interpolates option file hints in @ARGV by the contents of the pointed files. This enables option reading from files instead of or additional to the usual reading from the command line. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1301441 Note that current upstream release is under Artistic 1.0, but the author has agreed to relicense under Artistic 2.0 and grants permission to release the current version under Artistic 2.0. A copy of the email is included in the package.
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1301441 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 42117db2af4a24c062b2da25d4fdf756 Getopt-ArgvFile-1.11.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=10, Tests=43, 0 wallclock secs ( 0.02 usr 0.02 sys + 0.26 cusr 0.06 csys = 0.36 CPU) + Package perl-Getopt-ArgvFile-1.11-1.fc11.noarch => Provides: perl(Getopt::ArgvFile) Requires: perl >= 0:5.003 perl(Carp) perl(Cwd) perl(Exporter) perl(File::Basename) perl(File::Spec::Functions) perl(Text::ParseWords) perl(strict) APPROVED.
New Package CVS Request ======================= Package Name: perl-Getopt-ArgvFile Short Description: Interpolates script options from files into @ARGV or another array Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Getopt-ArgvFile-1.11-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Getopt-ArgvFile-1.11-2.fc11
perl-Getopt-ArgvFile-1.11-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Getopt-ArgvFile-1.11-2.fc10
Thanks for the review! :-)
perl-Getopt-ArgvFile-1.11-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Getopt-ArgvFile-1.11-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-Getopt-ArgvFile-1.11-24.el7 perl-PAR-1.015-4.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe2035adcd
perl-Getopt-ArgvFile-1.11-24.el7, perl-PAR-1.015-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe2035adcd
perl-Getopt-ArgvFile-1.11-24.el7 perl-PAR-1.015-4.el7 perl-PAR-Packer-1.041-2.el7 perl-Tk-Canvas-GradientColor-1.06-10.el7 perl-Tk-ColoredButton-1.05-15.el7 perl-Tk-EntryCheck-0.04-15.el7 perl-Tk-Getopt-0.51-3.el7 perl-Tk-Pod-0.9943-6.el7 perl-perlindex-1.606-10.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe2035adcd
perl-Getopt-ArgvFile-1.11-24.el7, perl-PAR-1.015-4.el7, perl-PAR-Packer-1.041-2.el7, perl-Tk-Canvas-GradientColor-1.06-10.el7, perl-Tk-ColoredButton-1.05-15.el7, perl-Tk-EntryCheck-0.04-15.el7, perl-Tk-Getopt-0.51-3.el7, perl-Tk-Pod-0.9943-6.el7, perl-perlindex-1.606-10.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-fe2035adcd
Please don't open closed package review bugs. This is closed in 2009 and you added them to this 2017 update.
perl-Getopt-ArgvFile-1.11-24.el7, perl-PAR-1.015-4.el7, perl-PAR-Packer-1.041-2.el7, perl-Tk-Canvas-GradientColor-1.06-10.el7, perl-Tk-ColoredButton-1.05-15.el7, perl-Tk-EntryCheck-0.04-15.el7, perl-Tk-Getopt-0.51-3.el7, perl-Tk-Pod-0.9943-6.el7, perl-perlindex-1.606-10.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.