Bug 496167 - Review Request: lilyterm - Light and easy to use X Terminal Emulator
Summary: Review Request: lilyterm - Light and easy to use X Terminal Emulator
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Susi Lehtola
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-16 22:01 UTC by Christoph Wickert
Modified: 2009-05-25 21:16 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-19 02:23:26 UTC
susi.lehtola: fedora-review+
cwickert: fedora-cvs+


Attachments (Terms of Use)

Description Christoph Wickert 2009-04-16 22:01:41 UTC
Spec URL: http://cwickert.fedorapeople.org/review/lilyterm.spec
SRPM URL: http://cwickert.fedorapeople.org/review/lilyterm-0.9.6-1.fc11.src.rpm
Description: LilyTerm is a light and easy to use libvte based X Terminal Emulator with a lot of features:
 * Supports multiple tabs, reorderable tabs and hides the tab tray when there 
   is only one tab
 * Add, close, swith, move, rename tabs with function keys
 * Disable/Enable function keys for temporary (use <Ctrl><`> by default).
 * Shows the foreground running command on tab and/or window title.
 * Change the font name, size, and window size with right click menu.
 * User custom function keys (need to edit profile).
 * Support for User/System profiles.
 * Supports true transparency if the window manager is composited.
 * Support for transparent background and background saturation.
 * Support for text and background color (need to edit profile).
 * Good support for UTF-8.
 * Decide the text encoding via environment. Using UTF-8 by default.
 * Change the text encoding with right click menu.

Note: Maybe the description is to elaborate, I know.

Comment 1 Susi Lehtola 2009-04-18 07:58:12 UTC
rpmlint output is clean.

MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK
MUST: The spec file for the package is legible and macros are used consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the  Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license. OK
MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

No problems here.

APPROVED

Comment 2 Christoph Wickert 2009-04-18 08:11:33 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: lilyterm
Short Description: Light and easy to use X Terminal Emulator
Owners: cwickert
Branches: F-9 F-10 F-11
InitialCC:

Comment 3 Kevin Fenzi 2009-04-19 01:27:10 UTC
cvs done.

Comment 4 Christoph Wickert 2009-04-19 01:51:49 UTC
Where is the F-9 branch?

Comment 5 Christoph Wickert 2009-04-19 01:52:26 UTC
My bad, was blind

Comment 6 Fedora Update System 2009-04-19 02:19:29 UTC
lilyterm-0.9.6-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/lilyterm-0.9.6-1.fc11

Comment 7 Fedora Update System 2009-04-19 02:20:56 UTC
lilyterm-0.9.6-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/lilyterm-0.9.6-1.fc10

Comment 8 Fedora Update System 2009-04-19 02:21:12 UTC
lilyterm-0.9.6-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/lilyterm-0.9.6-1.fc9

Comment 9 Fedora Update System 2009-05-25 21:13:29 UTC
lilyterm-0.9.6-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-05-25 21:14:31 UTC
lilyterm-0.9.6-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2009-05-25 21:16:45 UTC
lilyterm-0.9.6-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.