Spec URL: http://cwickert.fedorapeople.org/review/termit.spec SRPM URL: http://cwickert.fedorapeople.org/review/termit-2.2.0-1.fc11.src.rpm Description: TermIt is a simple terminal emulator based on vte library with a lot of features: * tabs * bookmarks * sessions * changing tab name * changing font for tabs * encodings (all available from GTK2) * integrated lua interpreter Configuration can be changed via $HOME/.config/termit/termit.cfg file.
- Why is the test phase commented out? rpmlint output is clean. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. ~OK - No license is mentioned in any of the source code files or documentation. - GPLv2 COPYING is attached and homepage specifies GPLv2. - Please contact upstream to clarify license in tarball. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. OK MUST: Optflags are used and time stamps preserved. OK MUST: Packages containing shared library files must call ldconfig. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Header files must be in a -devel package. OK MUST: Static libraries must be in a -static package. OK MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. OK MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. OK MUST: Packages does not contain any .la libtool archives. OK MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK No blockers, APPROVED
(In reply to comment #1) > - Why is the test phase commented out? Because it's in the cmake page of the wiki, but... Start processing tests Test project /home/chris/fedora/rpmbuild/BUILD/termit-2.2.0 No tests were found!!! If there are tests in a new release, I can easily enable the tests again. > - Please contact upstream to clarify license in tarball. Will do. Thanks for the review!
Reply from upstream: License is GPLv2 only, so my guess was right. New Package CVS Request ======================= Package Name: termit Short Description: Simple terminal emulator based on vte library Owners: cwickert Branches: F-9 F-10 F-11 InitialCC:
cvs done.
termit-2.2.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/termit-2.2.0-1.fc11
termit-2.2.0-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/termit-2.2.0-1.fc10
termit-2.2.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
termit-2.2.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.