Bug 496313 - Duplicate verify methods in UserManager & ChannelManager
Summary: Duplicate verify methods in UserManager & ChannelManager
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Spacewalk
Classification: Community
Component: WebUI
Version: 0.6
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jesus M. Rodriguez
QA Contact: Red Hat Satellite QA List
URL:
Whiteboard:
Depends On:
Blocks: space06
TreeView+ depends on / blocked
 
Reported: 2009-04-17 18:41 UTC by Jesus M. Rodriguez
Modified: 2009-07-22 18:35 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-07-22 18:35:20 UTC
Embargoed:

Attachments (Terms of Use)

Description Jesus M. Rodriguez 2009-04-17 18:41:57 UTC 
UserManager has verifyChannelAdmin, verifyChannelSubscribable, verifyChannelRole
ChannelManager ALSO has verifyChannelAdmin, verifyChannelSubscribable, verifyChannelRole
and they do the same thing except ChannelManager throws an exception
Comment 1 Jesus M. Rodriguez 2009-04-17 18:43:28 UTC 
PROPOSED REFACTORING
---------------------
1) make UserManager methods throw InvalidChannelRoleException
2) remove the methods from ChannelManager
3) change the folks using CHannelManager to use UserManager.
4) TEST!!!
Note You need to log in before you can comment on or make changes to this bug.