Red Hat Bugzilla – Bug 496424
Review Request: perl-Test-Aggregate - Aggregate C<*.t> tests to make them run faster
Last modified: 2009-04-21 17:26:38 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Test-Aggregate.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Test-Aggregate-0.35-1.fc10.src.rpm Description: *WARNING*: this is ALPHA code. The interface is not guaranteed to be stable. A common problem with many test suites is that they can take a long time to run. The longer they run, the less likely you are to run the tests. This module borrows a trick from 'Apache::Registry' to load up your tests at once, create a separate package for each test and wraps each package in a method named 'run_the_tests'. This allows us to load perl only once and related modules only once. If you have modules which are expensive to load, this can dramatically speed up a test suite. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1307346 Additional Comment: This package is a new BR of Catalyst::Runtime 5.80001 *rt-0.06
+ source files match upstream. 495a0c853951d326df5322e97bcbc9c53a71eea9 Test-Aggregate-0.35.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + summary is OK. + description is OK. + dist tag is present. + build root is OK. + license field matches the actual license. GPL+ or Artistic + license is open source-compatible. + license text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package builds in mock http://koji.fedoraproject.org/koji/taskinfo?taskID=1307346 + package installs properly. + rpmlint has no complaints: perl-Test-Aggregate.noarch: I: checking perl-Test-Aggregate.src: I: checking 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + final provides and requires are sane: perl(Test::Aggregate) = 0.35 perl(Test::Aggregate::Builder) = 0.35 perl-Test-Aggregate = 0.35-1.fc11 = perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(File::Find) perl(Test::Aggregate) perl(Test::Aggregate::Builder) perl(Test::Builder) perl(Test::Builder::Module) perl(Test::More) perl(strict) perl(vars) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 + %check is present and all tests pass. All tests successful. Files=5, Tests=48, 4 wallclock secs ( 0.07 usr 0.02 sys + 0.58 cusr 0.07 csys = 0.74 CPU) Result: PASS + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no generically named files + code, not content. + documentation is small, so no -doc subpackage is necessary. + %docs are not necessary for the proper functioning of the package. APPROVED.
New Package CVS Request ======================= Package Name: perl-Test-Aggregate Short Description: Aggregate C<*.t> tests to make them run faster Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
I assume you want a F-11 branch here as well. cvs done with F-11 added.
Thanks for the review! :-)