Spec URL: http://fedorapeople.org/~iarnell/review/perl-Lexical-Persistence.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Lexical-Persistence-0.98-1.fc12.src.rpm Description: Lexical::Persistence does a few things, all related. Note that all the behaviors listed here are the defaults. Subclasses can override nearly every aspect of Lexical::Persistence's behavior. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1307872 *rt-0.06
There's an examples directory (eg/), why not include it in %doc? koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1307872 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): c2e97f5008c68f0b9f7f643a9ce4b21bfee572d7 Lexical-Persistence-0.98.tar.gz c2e97f5008c68f0b9f7f643a9ce4b21bfee572d7 Lexical-Persistence-0.98.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Lexical-Persistence-0.98-1.fc10.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Lexical-Persistence-0.98-1.fc10.src.rpm ====> requires for perl-Lexical-Persistence-0.98-1.fc10.src.rpm perl(Devel::LexAlias) >= 0.04 perl(ExtUtils::MakeMaker) perl(PadWalker) >= 1.1 perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) =====> perl-Lexical-Persistence-0.98-1.fc10.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Lexical-Persistence-0.98-1.fc10.noarch.rpm perl(Lexical::Persistence) = 0.98 perl-Lexical-Persistence = 0.98-1.fc10 ====> requires for perl-Lexical-Persistence-0.98-1.fc10.noarch.rpm perl(:MODULE_COMPAT_5.10.0) perl(Devel::LexAlias) perl(PadWalker) perl(strict) perl(warnings) APPROVED
New Package CVS Request ======================= Package Name: perl-Lexical-Persistence Short Description: Persistent lexical variable values for arbitrary calls Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Lexical-Persistence-0.98-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Lexical-Persistence-0.98-1.fc10
perl-Lexical-Persistence-0.98-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Lexical-Persistence-0.98-1.fc11
Thanks for the review! :-)
perl-Lexical-Persistence-0.98-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Lexical-Persistence-0.98-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.