Spec URL: http://fedorapeople.org/~iarnell/review/perl-WWW-Pastebin-RafbNet-Create.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc12.src.rpm Description: The module provides means to create new pastes on http://rafb.net/ paste site. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1307894 *rt-0.06
There's an examples/ directory; why not include it under %doc? There's a missing dep on Class::Data::Accessor, due to a 'use base' construct. Please add this before building... Otherwise, looks good. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1307894 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): af8ee45f6bbf1efede1c725ae6556a529199f29d WWW-Pastebin-RafbNet-Create-0.001.tar.gz af8ee45f6bbf1efede1c725ae6556a529199f29d WWW-Pastebin-RafbNet-Create-0.001.tar.gz.srpm Final provides / requires are sane (with the above caveat): 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.src.rpm ====> requires for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.src.rpm perl(Class::Data::Accessor) >= 0.04001 perl(LWP::UserAgent) >= 2.036 perl(Module::Build) perl(Test::Kwalitee) perl(Test::More) perl(Test::Pod) perl(Test::Pod::Coverage) perl(URI) >= 1.35 =====> perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.noarch.rpm perl(WWW::Pastebin::RafbNet::Create) = 0.001 perl-WWW-Pastebin-RafbNet-Create = 0.001-1.fc10 ====> requires for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.noarch.rpm perl(base) perl(Carp) perl(LWP::UserAgent) perl(:MODULE_COMPAT_5.10.0) perl(overload) perl(strict) perl(URI) perl(warnings) APPROVED
New Package CVS Request ======================= Package Name: perl-WWW-Pastebin-RafbNet-Create Short Description: Create new pastes on http://rafb.net/ Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-WWW-Pastebin-RafbNet-Create-0.001-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-WWW-Pastebin-RafbNet-Create-0.001-2.fc10
perl-WWW-Pastebin-RafbNet-Create-0.001-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-WWW-Pastebin-RafbNet-Create-0.001-2.fc11
Thanks for the review! :-)
perl-WWW-Pastebin-RafbNet-Create-0.001-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-WWW-Pastebin-RafbNet-Create-0.001-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.