Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-MethodAttributes.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-MethodAttributes-0.06-1.fc10.src.rpm Description: This module allows code attributes of methods to be introspected using Moose meta method objects. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1310691 Additional Comment: This package is a new BR of Catalyst::Runtime 5.80001. *rt-0.06
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-MethodAttributes.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-MethodAttributes-0.06-2.fc10.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1310695
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1310695 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9db312b0fe2b5311aac1f7c68b3133df MooseX-MethodAttributes-0.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=12, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.86 cusr 0.06 csys = 1.98 CPU) + Package perl-MooseX-MethodAttributes-0.06-2.fc11.noarch => Provides: perl(MooseX::MethodAttributes) = 0.06 perl(MooseX::MethodAttributes::Inheritable) = 0.06 perl(MooseX::MethodAttributes::Role::AttrContainer) = 0.06 perl(MooseX::MethodAttributes::Role::AttrContainer::Inheritable) = 0.06 perl(MooseX::MethodAttributes::Role::Meta::Class) = 0.06 perl(MooseX::MethodAttributes::Role::Meta::Method) = 0.06 perl(MooseX::MethodAttributes::Role::Meta::Method::MaybeWrapped) = 0.06 perl(MooseX::MethodAttributes::Role::Meta::Method::Wrapped) = 0.06 Requires: perl(Moose) perl(Moose::Exporter) perl(Moose::Role) perl(Moose::Util) perl(Moose::Util::MetaRole) perl(MooseX::MethodAttributes::Role::Meta::Method::Wrapped) perl(MooseX::Types::Moose) perl(namespace::clean) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-MooseX-MethodAttributes Short Description: Introspect your code attributes Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
cvs done. (Oh, I assumed you wanted F-11 on all these requests... you might update your template to include it moving forward).
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-MooseX-MethodAttributes New Branches: el6 Owners: iarnell tremble InitialCC: perl-sig
Git done (by process-git-requests).
perl-MooseX-MethodAttributes-0.24-2.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-00e77e737b
perl-MooseX-MethodAttributes-0.24-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-00e77e737b
perl-MooseX-MethodAttributes-0.24-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.