Spec URL: http://fedorapeople.org/~cweyl/review/perl-RT-Client-REST.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-RT-Client-REST-0.37-1.fc10.src.rpm Description: *RT::Client::REST* is */usr/bin/rt* converted to a Perl module. I needed to implement some RT interactions from my application, but did not feel that invoking a shell command is appropriate. Thus, I took *rt* tool, written by Abhijit Menon-Sen, and converted it to an object-oriented Perl module. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1310693 *rt-0.06
Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1310693 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 383bf572afdb8040641d4d413ef96476 RT-Client-REST-0.37.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=15, Tests=325, 24 wallclock secs ( 0.16 usr 0.03 sys + 5.09 cusr 0.31 csys = 5.59 CPU) + Package perl-RT-Client-REST-0.37-1.fc11.noarch => Provides: perl(RT::Client::REST) = 0.37 perl(RT::Client::REST::Attachment) = 0.03 perl(RT::Client::REST::Exception) = 0.19 perl(RT::Client::REST::Forms) perl(RT::Client::REST::HTTPClient) = 0.01 perl(RT::Client::REST::Object) = 0.09 perl(RT::Client::REST::Object::Exception) = 0.05 perl(RT::Client::REST::Queue) = 0.02 perl(RT::Client::REST::SearchResult) = 0.03 perl(RT::Client::REST::Ticket) = 0.09 perl(RT::Client::REST::Transaction) = 0.01 perl(RT::Client::REST::User) = 0.02 Requires: perl(Error) perl(Exception::Class) perl(Exporter) perl(HTTP::Cookies) perl(HTTP::Request::Common) perl(Params::Validate) perl(RT::Client::REST) >= 0.14 perl(RT::Client::REST) >= 0.18 perl(RT::Client::REST) >= 0.20 perl(RT::Client::REST::Attachment) perl(RT::Client::REST::Exception) perl(RT::Client::REST::Exception) >= 0.18 perl(RT::Client::REST::Forms) perl(RT::Client::REST::HTTPClient) perl(RT::Client::REST::Object) >= 0.01 perl(RT::Client::REST::Object::Exception) >= 0.01 perl(RT::Client::REST::Object::Exception) >= 0.03 perl(RT::Client::REST::Object::Exception) >= 0.04 perl(RT::Client::REST::SearchResult) >= 0.02 perl(RT::Client::REST::Ticket) perl(RT::Client::REST::Transaction) perl(base) perl(strict) perl(vars) perl(warnings) Also, Strange to see requires perl(RT::Client::REST::Object::Exception) >= 0.01 perl(RT::Client::REST::Object::Exception) >= 0.03 perl(RT::Client::REST::Object::Exception) >= 0.04 Do we really need to care to filter 2 of them? APPROVED.
New Package CVS Request ======================= Package Name: perl-RT-Client-REST Short Description: Talk to RT using REST protocol Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
(In reply to comment #1) > Also, > Strange to see requires > perl(RT::Client::REST::Object::Exception) >= 0.01 > perl(RT::Client::REST::Object::Exception) >= 0.03 > perl(RT::Client::REST::Object::Exception) >= 0.04 > Do we really need to care to filter 2 of them? Yeah, it's weird but outside of filtering them there isn't much we can do about it. The most restrictive one wins (the last one in this case), and nothing "bad" will happen due to this, so I don't think it's really worth filtering the redundant ones out.
cvs done.
Thanks for the review! :-)