Bug 496825 - Review Request: ipa-pgothic-fonts - Japanese Proportional Gothic-typeface OpenType font by IPA
Summary: Review Request: ipa-pgothic-fonts - Japanese Proportional Gothic-typeface Ope...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-21 11:04 UTC by Akira TAGOH
Modified: 2009-04-23 11:39 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-04-23 11:39:01 UTC
Type: ---
Embargoed:
panemade: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Akira TAGOH 2009-04-21 11:04:40 UTC
Spec URL: http://tagoh.fedorapeople.org/ipa-pgothic-fonts/ipa-pgothic-fonts.spec
SRPM URL: http://tagoh.fedorapeople.org/ipa-pgothic-fonts/ipa-pgothic-fonts-003.01-1.fc10.src.rpm
Description:

IPA Font is a Japanese OpenType fonts that is JIS X 0213:2004
compliant, provided by Information-technology Promotion Agency, Japan.

This package contains Proportional Gothic (sans-serif) style font.

Comment 1 Parag AN(पराग) 2009-04-21 13:18:30 UTC
I think correct Source URL is http://info.openlab.ipa.go.jp/ipafont/fontdata/ipagp00301.zip

Comment 3 Parag AN(पराग) 2009-04-22 08:01:29 UTC
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1313839
+ rpmlint output for SRPM and for RPM.
ipa-pgothic-fonts.src: W: invalid-license IPA
ipa-pgothic-fonts.noarch: W: invalid-license IPA
==> ignored as its present in wiki list. rpmlint need to be updated.

+ source files match upstream url
ab5e7e962b358a5579d08f09a9d07ebf  ipagp00301.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts packaging guidelines used.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI App.
APPROVED.

Comment 4 Akira TAGOH 2009-04-22 08:16:23 UTC
Thanks for reviewing.

New Package CVS Request
=======================
Package Name: ipa-pgothic-fonts
Short Description: Japanese Proportional Gothic-typeface OpenType font by IPA
Owners: tagoh
Branches: devel F-11 F-10 F-9
InitialCC: fonts-sig

Comment 5 Jens Petersen 2009-04-23 02:12:49 UTC
cvs done

Comment 6 Akira TAGOH 2009-04-23 11:39:01 UTC
available on koji now. thanks.


Note You need to log in before you can comment on or make changes to this bug.