Bug 497162 - gpk-update-viewer attempts to apply formatting to changelog entries
Summary: gpk-update-viewer attempts to apply formatting to changelog entries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-packagekit
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Richard Hughes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-22 15:43 UTC by Will Woods
Modified: 2009-06-16 02:23 UTC (History)
2 users (show)

Fixed In Version: 2.27.2-1.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-04-22 16:41:32 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
screenshot of gpk-update-viewer formatting the changelog entries for kernel (99.48 KB, image/png)
2009-04-22 15:43 UTC, Will Woods
no flags Details

Description Will Woods 2009-04-22 15:43:05 UTC
Created attachment 340765 [details]
screenshot of gpk-update-viewer formatting the changelog entries for kernel

If there's no update metadata to show, gpk-update-viewer now shows the changelog. (Which is awesome.) But it tries to format the changelog entries like it does the update metadata, so strings like:
  CONFIG_UEVENT_HELPER_PATH
get rendered like: CONFIG<i>UEVENT</i>HELPER_PATH

See the attached screenshot for an example.

Comment 1 Richard Hughes 2009-04-22 16:39:43 UTC
Right. I would argue that putting CONFIG_UEVENT_HELPER_PATH in the ChangeLog is a bit of a waste of time, as that's not going to mean much to 99% of the population. I would however concede that the ChangeLog is a developer feature, where users should be getting information from bohdi, and the ChangeLog is only shown for rawhide where there's no better data.

I still think it makes sense to format this, but we need to add special programmer cases like this. In this case I think we just need to make the markdown parser a little bit cleverer.

Richard.

Comment 2 Richard Hughes 2009-04-22 16:41:32 UTC
commit 04424457c9be4d42a68f8bc2e9b2d40e2a331ddc
Author: Richard Hughes <richard>
Date:   Wed Apr 22 17:39:22 2009 +0100

    Enable autocode for compiler defines in the markdown parser. Fixes rh#497162

This will be present in gnome-packagekit 2.27.2, which is released on the 2nd May. It'll be pushed as an F11 update. Thanks for reporting this.

Richard.

Comment 3 Fedora Update System 2009-06-01 10:57:05 UTC
gnome-packagekit-2.27.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/gnome-packagekit-2.27.2-1.fc11

Comment 4 Fedora Update System 2009-06-16 02:22:34 UTC
gnome-packagekit-2.27.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.