Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-StripScripts.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-HTML-StripScripts-1.04-1.fc10.src.rpm Description: This module strips scripting constructs out of HTML, leaving as much non-scripting markup in place as possible. This allows web applications to display HTML originating from an untrusted source without introducing XSS (cross site scripting) vulnerabilities.
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1325851 + rpmlint is silent for SRPM and for RPM. + source files match upstream url aecd01e273bddbf60dca2a923163826d HTML-StripScripts-1.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=12, Tests=1894, 2 wallclock secs ( 0.04 usr 0.07 sys + 1.48 cusr 0.10 csys = 1.69 CPU) + Package perl-HTML-StripScripts-1.04-1.fc12.noarch => Provides: perl(HTML::StripScripts) = 1.04 Requires: perl(strict) perl(vars) perl(warnings) Suggestions: 1) you don't need Requires: perl(Test::More) remove it from SPEC APPROVED.
Thanks for the review Parag. I'll fix the point you outlined above before building. New Package CVS Request ======================= Package Name: perl-HTML-StripScripts Short Description: Strip scripting constructs out of HTML Owners: xavierb Branches: F-9 F-10 F-11 EL-5 InitialCC: perl-sig
cvs done.
perl-HTML-StripScripts-1.04-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-HTML-StripScripts-1.04-1.fc10
perl-HTML-StripScripts-1.04-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-HTML-StripScripts-1.04-1.fc9
perl-HTML-StripScripts-1.04-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-HTML-StripScripts-1.04-1.fc11
perl-HTML-StripScripts-1.04-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
perl-HTML-StripScripts-1.04-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-HTML-StripScripts-1.04-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.