Red Hat Bugzilla – Bug 497869
Review Request: perl-MooseX-Role-XMLRPC-Client - Provide the needed bits to be a XML-RPC client
Last modified: 2009-05-01 23:55:21 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Role-XMLRPC-Client.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Role-XMLRPC-Client-0.03-1.fc10.src.rpm
This is a Moose role that provides the methods and attributes needed
to enable a class to serve as an XML-RPC client. It is parameterized
through MooseX::Role::Parameterized, so you can customize how it embeds
in your class. You can even embed it multiple times with different
paramaterization, if it strikes your fancy :-)
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1323070
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1323070
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=30, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.22 cusr 0.10 csys = 1.36 CPU)
+ Package perl-MooseX-Role-XMLRPC-Client-0.03-1.fc12.noarch =>
Provides: perl(MooseX::Role::XMLRPC::Client) = 0.03
Requires: perl(HTTP::Cookies) perl(MooseX::Role::Parameterized) perl(MooseX::Types::Moose) perl(MooseX::Types::Path::Class) perl(MooseX::Types::URI) perl(RPC::XML::Client) perl(namespace::clean)
New Package CVS Request
Package Name: perl-MooseX-Role-XMLRPC-Client
Short Description: Provide the needed bits to be a XML-RPC client
Branches: F-9 F-10 F-11 devel
Thanks for the review! :-)