Bug 498040 - intermittent crashes on prototype kprobe.function("foo") probes for erroneous "foo"
Summary: intermittent crashes on prototype kprobe.function("foo") probes for erroneous...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: systemtap
Version: 5.4
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Josh Stone
QA Contact: BaseOS QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-28 15:48 UTC by Frank Ch. Eigler
Modified: 2009-09-02 10:01 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-02 10:01:21 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Backport fixes for dwarfless kprobes (8.01 KB, patch)
2009-04-28 22:57 UTC, Josh Stone
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2009:1313 0 normal SHIPPED_LIVE systemtap bug fix and enhancement update 2009-09-01 10:25:25 UTC

Description Frank Ch. Eigler 2009-04-28 15:48:48 UTC
A bug in the new code for debuginfo-less probing in 0.9.7 may result in
occasional kernel BUG/crashes, when the function parameter causes
a failed registration.  I believe Josh has a reproducing recipe (please
attach here), and also has two or three patches on mainline systemtap
that could be backported to rhel5.4's new build.

Comment 1 Josh Stone 2009-04-28 19:18:39 UTC
I have a reproducer that works on Fedora, but when I tried it on RHEL5.4, I discovered that the debuginfo-less probing is completely broken.  It doesn't get past the compile phase with a simple probe, so we never even get to the potential BUG point in the kernel.

I will put together a patch which fixes the compile problems and also fixes the runtime BUG.

Comment 2 Josh Stone 2009-04-28 22:57:15 UTC
Created attachment 341665 [details]
Backport fixes for dwarfless kprobes

This is a backport of a few fixes for dwarfless kprobes that were
made after the 0.9.7 release.  The upstream commits are:

5badd4d... Don't terminate when a dwarfless kprobe fails
46856d8... Fill out the pp() for dwarfless kprobes
8874701... fix kprobe.* probes so they don't break -p4 if script
           also has kernel.* probes
9f38e65... Handle kprobe struct field symbol_name as either char *
           or const char *.

Comment 9 errata-xmlrpc 2009-09-02 10:01:21 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-1313.html


Note You need to log in before you can comment on or make changes to this bug.