Bug 498191 - Review Request: perl-ExtUtils-InstallPAR - Install .par's into any installed perl
Summary: Review Request: perl-ExtUtils-InstallPAR - Install .par's into any installed ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-29 12:05 UTC by Marcela Mašláňová
Modified: 2009-05-04 08:03 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-05-04 08:03:19 UTC
Type: ---
Embargoed:
panemade: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Marcela Mašláňová 2009-04-29 12:05:21 UTC
Spec URL: http://mmaslano.fedorapeople.org/review/perl-ExtUtils-InstallPAR.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-ExtUtils-InstallPAR-0.03-1.fc11.src.rpm
Description:
This module installs PAR distributions (i.e. .par files) into any perl
installation on the system. The PAR::Dist module can install into the
currently running perl by default and provides the necessary parameters to
override any installation directories. Figuring out how to use those
overrides in order to install into an arbitrary perl installation on the
system may be beyond most users, however. Hence this convenience wrapper
using ExtUtils::InferConfig to automatically determine the typical site
installation paths of any perl interpreter than can be executed by the
current user.

Comment 1 Parag AN(पराग) 2009-04-30 04:37:25 UTC
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1329657
Build failed.
Need BR: perl(Test::More)

Comment 3 Parag AN(पराग) 2009-04-30 08:40:20 UTC
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1329831
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
88832cdff670a78bb44e25cadd700f4d  ExtUtils-InstallPAR-0.03.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=1,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.07 cusr  0.01 csys =  0.11 CPU)
+ Package perl-ExtUtils-InstallPAR-0.03-2.fc12.noarch =>
Provides: perl(ExtUtils::InstallPAR) = 0.03
Requires: perl(Carp) perl(Config) perl(Exporter) perl(File::Spec) perl(PAR::Dist) perl(strict) perl(vars)
+ Not a GUI application

APPROVED.

Comment 4 Marcela Mašláňová 2009-04-30 08:53:07 UTC
New Package CVS Request
=======================
Package Name: perl-ExtUtils-InstallPAR
Short Description: Install .par's into any installed perl
Owners: mmaslano
Branches: F-11
InitialCC: perl-sig

Comment 5 Dennis Gilmore 2009-05-01 21:00:48 UTC
CVS Done


Note You need to log in before you can comment on or make changes to this bug.