Bug 498196 - Review Request: perl-WebService-Validator-CSS-W3C - Interface to the W3C CSS Validator
Review Request: perl-WebService-Validator-CSS-W3C - Interface to the W3C CSS ...
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-29 08:22 EDT by Marcela Mašláňová
Modified: 2009-04-30 01:50 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-04-30 01:50:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Marcela Mašláňová 2009-04-29 08:22:51 EDT
Spec URL: http://mmaslano.fedorapeople.org/review/perl-WebService-Validator-CSS-W3C.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-WebService-Validator-CSS-W3C-0.2-1.fc11.src.rpm
Description:
This module is an interface to the W3C CSS Validation online service 
http://jigsaw.w3.org/css-validator/, based on its SOAP 1.2 support. 
It helps to find errors in Cascading Style Sheets.
Comment 1 Parag AN(पराग) 2009-04-29 11:58:52 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328750
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bac54611541f72e1cfd12949afae9a1f  WebService-Validator-CSS-W3C-0.2.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
 Files=1, Tests=3,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.23 cusr  0.01 csys =  0.29 CPU)
+ Package perl-WebService-Validator-CSS-W3C-0.2-1.fc12.noarch =>
Provides: perl(WebService::Validator::CSS::W3C) = 0.2
Requires: perl(Carp) perl(LWP::UserAgent) perl(SOAP::Lite) >= 0.65 perl(URI) perl(URI::QueryParam) perl(base) perl(strict) perl(warnings)

APPROVED
Comment 2 Marcela Mašláňová 2009-04-29 12:24:08 EDT
New Package CVS Request
=======================
Package Name: perl-WebService-Validator-CSS-W3C
Short Description: Interface to the W3C CSS Validator
Owners: mmaslano
Branches: F-11
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-04-30 01:01:49 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.