Bug 498214 - Review Request: gausssum - A GUI application for analysis of output of quantum computations
Summary: Review Request: gausssum - A GUI application for analysis of output of quantu...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Christoph Wickert
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 497338
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-04-29 13:47 UTC by Susi Lehtola
Modified: 2009-05-09 04:25 UTC (History)
3 users (show)

Fixed In Version: 2.1.6-3.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-06 23:32:54 UTC
Type: ---
Embargoed:
christoph.wickert: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Susi Lehtola 2009-04-29 13:47:19 UTC
Spec URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum.spec

SRPM URL:
http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum-2.1.6-1.fc10.src.rpm

Description:
GaussSum is a GUI application that can analyse the output of ADF, GAMESS (US),
GAMESS-UK, Gaussian, Jaguar and PC GAMESS to extract and calculate useful
information. This includes the progress of the SCF cycles, geometry
optimisation, UV-Vis/IR/Raman spectra, MO levels, MO contributions and more.


rpmlint output is clean.

Comment 1 Christoph Wickert 2009-05-02 23:23:53 UTC
REVIEW FOR 2b5e5173d73f6484b08e5279ba737f5c  gausssum-2.1.6-1.fc10.src.rpm

OK - MUST: rpmlint must be run on every package. The output should be posted in the review.
$ rpmlint /var/lib/mock/fedora-rawhide-i386/result/gausssum-2.1.6-1.fc11.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: The package is named according to the Package Naming Guidelines.
OK - MUST: The spec file name matches the base package %{name}, in the format %{name}.spec.
OK - MUST: The package meets the Packaging Guidelines.
OK - MUST: The package is licensed with a Fedora approved license and meets the Licensing Guidelines: GPLv2+
OK - MUST: The License field in the package spec file matches the actual license.
OK - MUST: The license file from the source package is included in %doc.
OK - MUST: The spec file is in American English.
Ok - MUST: The spec file for the package is legible.
OK - MUST: The sources used to build the package match the upstream source by MD5 80d0c796f1fc8d2959bb28a8e9f09d58
OK - MUST: The package successfully compiles and builds into binary rpms on i386
N/A - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. (noarch)
OK - MUST: All build dependencies are listed in BuildRequires.
N/A - MUST: The spec file handles locales properly with the %find_lang macro.
N/A - MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
N/A - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package.
OK - MUST: The package owns all directories that it creates.
OK - MUST: The package does not contain any duplicate files in the %files listing.
OK - MUST: Permissions on files are set properly. Every %files section includes a %defattr(...) line.
OK - MUST: The package has a %clean section, which contains rm -rf %{buildroot}.
OK - MUST: The package consistently uses macros, as described in the macros section of Packaging Guidelines.
OK - MUST: The package contains code, or permissable content.
OK - MUST: Large documentation files should go in a -doc subpackage.
OK - MUST: Files included as %doc do not affect the runtime of the application.
N/A - MUST: Header files must be in a -devel package.
N/A - MUST: Static libraries must be in a -static package.
N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
N/A - MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package.
N/A - MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release}
OK - MUST: The package does not contain any .la libtool archives.
FIX - MUST: The package contains a GUI application but does not include a %{name}.desktop file.
OK - MUST: The packages does not own files or directories already owned by other packages.
OK - MUST: At the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: All filenames in rpm packages are valid UTF-8.


SHOULD Items:
FIX - SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
N/A - SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
OK - SHOULD: The the package builds in mock.
OK - SHOULD: The package should compile and build into binary rpms on all supported architectures.
OK - SHOULD: The package functions as described. Although I have to admit that I don't have a clue what is really does... :)
N/A - SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
N/A - SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
N/A - SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg.
N/A - SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.


Issues:
- I think you should include a desktop file.
- License text not included. Please poke upstream.
- Help -> Documentation does not work, it's liked to 
file:///usr/lib/python2.5/site-packages/gausssum/Docs/index.html
You should sed/patch this.
- File -> Settings -> Gnuplut is set to /usr/lib/python2.5/site-packages/gausssum/gnuplot400/bin/wgnuplot.exe by default.
You might want to fix this too.

Comment 2 Christoph Wickert 2009-05-02 23:27:19 UTC
Please preserver timestamps during cp.

Comment 3 Susi Lehtola 2009-05-03 06:45:17 UTC
(In reply to comment #1)
> Issues:
> - I think you should include a desktop file.
> - License text not included. Please poke upstream.
> - Help -> Documentation does not work, it's liked to 
> file:///usr/lib/python2.5/site-packages/gausssum/Docs/index.html
> You should sed/patch this.
> - File -> Settings -> Gnuplut is set to
> /usr/lib/python2.5/site-packages/gausssum/gnuplot400/bin/wgnuplot.exe by
> default.
> You might want to fix this too.  

Done.

(In reply to comment #2)
> Please preserver timestamps during cp.  

cp -a DOES preserve timestamps.

**

I also removed the included cclib, to install you need
https://bugzilla.redhat.com/show_bug.cgi?id=497338

http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum.spec
http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum-2.1.6-2.fc10.src.rpm

Comment 4 Christoph Wickert 2009-05-03 11:09:15 UTC
(In reply to comment #3)

> cp -a DOES preserve timestamps.

Sorry, seems like it was to late yesterday.

> I also removed the included cclib, to install you need
> https://bugzilla.redhat.com/show_bug.cgi?id=497338

Damn, I missed something really obvious.

> http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum.spec
> http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum-2.1.6-2.fc10.src.rpm  

Ok - Requirements look sane, should be covered by cclib. Too bad this package now pulls in PyQt4 and it's deps.
OK - Package builds in mock.
OK - Package includes a desktop file.
OK - Help -> Documentation works
OK - File -> Settings -> Gnuplut correct, Test works


Issues:
You are installing an icon into /usr/share/icons/hicolor/, but you are not running the gtk-update-icon-cache srciptlet. I would simply install to /usr/share/pixmaps, then you don't need to require hicolor-icon-theme.

Desktop file: "Analyze output of Quantum Chemistry packages" is a comment, not a GenericName. GenericName would be something like "Quantum computation analyzer" or just GaussSum.
Add more categories to allow nested menus: Chemistry (?), DataVisualization and Physics are good candidates I guess, see http://standards.freedesktop.org/menu-spec/latest/apa.html

IMHO you should just symlink GaussSum.py instead of excluding it's pyc and pyo as you did in the previous package, but this is up to you.

Apply fixes and consider this package

APPROVED.

Comment 5 Susi Lehtola 2009-05-03 11:41:08 UTC
Will do, thanks for the review!

New Package CVS Request
=======================
Package Name: gausssum
Short Description: A GUI application for analysis of output of quantum computations
Owners: jussilehtola
Branches: F-10 F-11
InitialCC:

Comment 6 Kevin Fenzi 2009-05-04 03:46:17 UTC
cvs done.

Comment 7 Fedora Update System 2009-05-04 06:45:22 UTC
gausssum-2.1.6-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/gausssum-2.1.6-3.fc10

Comment 8 Fedora Update System 2009-05-04 06:46:10 UTC
gausssum-2.1.6-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/gausssum-2.1.6-3.fc11

Comment 9 Fedora Update System 2009-05-06 23:32:49 UTC
gausssum-2.1.6-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-05-09 04:25:13 UTC
gausssum-2.1.6-3.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.