Spec URL: http://fedorapeople.org/~iarnell/review/perl-Perl-Tags.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Perl-Tags-0.26-1.fc12.src.rpm Description: Generate (possibly exuberant) Ctags style tags for Perl sourcecode. Recursively follows use and require statements, up to a maximum of max_level. The implemented tagger, Perl::Tags::Naive is a more-or-less straight ripoff, slightly updated, of the original pltags code, and is rather naive. It should be possible to subclass using something like PPI or Text::Balanced, though be aware that this is alpha software and the internals are subject to change. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1328528 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328528 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7ce83250ffa83ca25c40c9aaa9adc9b2 Perl-Tags-0.26.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=47, 4 wallclock secs ( 0.08 usr 0.03 sys + 1.51 cusr 0.16 csys = 1.78 CPU) + Package perl-Perl-Tags-0.26-1.fc12.noarch => Provides: perl(Perl::Tags) = 0.26 perl(Perl::Tags::Naive) perl(Perl::Tags::Naive::Lib) perl(Perl::Tags::Naive::Spiffy) perl(Perl::Tags::PPI) perl(Perl::Tags::Tag) perl(Perl::Tags::Tag::Constant) perl(Perl::Tags::Tag::Field) perl(Perl::Tags::Tag::Label) perl(Perl::Tags::Tag::Package) perl(Perl::Tags::Tag::Recurse) perl(Perl::Tags::Tag::Stub) perl(Perl::Tags::Tag::Sub) perl(Perl::Tags::Tag::Var) Requires: perl(Data::Dumper) perl(File::Spec) perl(Module::Locate) perl(PPI) perl(base) perl(overload) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Perl-Tags Short Description: Generate Ctags style tags for Perl sourcecode Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Perl-Tags-0.26-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Perl-Tags-0.26-1.fc11
perl-Perl-Tags-0.26-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Perl-Tags-0.26-1.fc10
Thanks for the review! :-)
perl-Perl-Tags-0.26-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Perl-Tags-0.26-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.