Bug 498329 - fence_drac5 help output shows incorrect usage
Summary: fence_drac5 help output shows incorrect usage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: cman
Version: 5.3
Hardware: All
OS: Linux
low
low
Target Milestone: rc
: ---
Assignee: Marek Grac
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks: 498870
TreeView+ depends on / blocked
 
Reported: 2009-04-29 21:04 UTC by John Ruemker
Modified: 2016-04-26 14:06 UTC (History)
5 users (show)

Fixed In Version: cman-2.0.100-1.el5
Doc Type: Bug Fix
Doc Text:
Cause: Typo in usage text of fence agent Result: Typo fixed
Clone Of:
: 498870 (view as bug list)
Environment:
Last Closed: 2009-09-02 11:10:28 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2009:1341 0 normal SHIPPED_LIVE Low: cman security, bug fix, and enhancement update 2009-09-01 10:43:16 UTC

Description John Ruemker 2009-04-29 21:04:00 UTC
Description of problem: The fence_drac5 fencing agent shows two different -D options in the help output:

# fence_drac5 -h 2>&1 | grep "\-D"
   -D <version>   Force DRAC version to use
   -D <debugfile> Debugging to output file

This is because fence_drac5 enables both the debug and drac_version options in the fencing library:

        device_opt = [  "help", "version", "agent", "quiet", "verbose", "debug",
                        "action", "ipaddr", "login", "passwd", "passwd_script",
                        "cmd_prompt", "secure",
                        "drac_version", "module_name" ]

And the drac_version help string is incorrect in fencing.py:

	"debug" : {
		"getopt" : "D:",
		"help" : "-D <debugfile> Debugging to output file",
		"order" : 52 },
--
	"drac_version" : {
		"getopt" : "d:",
		"help" : "-D <version>   Force DRAC version to use",
		"order" : 1 },


This should read:

	"drac_version" : {
		"getopt" : "d:",
		"help" : "-d <version>   Force DRAC version to use",
		"order" : 1 },

Note that this doesn't cause any actual problems with the operation of the agent (-d still forces the drac version to use), however it is confusing to users looking at the help message.

Version-Release number of selected component (if applicable): cman-2.0.99-1.el5


How reproducible: Always


Steps to Reproduce:
1. fence_drac5 -h
  
Actual results: Two -D options displayed


Expected results: One -D and one -d displayed

Comment 4 Marek Grac 2009-05-25 11:14:17 UTC
Release note added. If any revisions are required, please set the 
"requires_release_notes" flag to "?" and edit the "Release Notes" field accordingly.
All revisions will be proofread by the Engineering Content Services team.

New Contents:
Cause: Typo in usage text of fence agent
Result: Typo fixed

Comment 7 errata-xmlrpc 2009-09-02 11:10:28 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2009-1341.html


Note You need to log in before you can comment on or make changes to this bug.