Red Hat Bugzilla – Bug 498551
The short form for fcoeadm switch display output properly while long displays help screen.
Last modified: 2009-05-14 12:22:13 EDT
Description of problem:
when using the short form (fcoeadm -i) of fcoeadm switches, fcoeadm works as expected but when using the long form (fcoeadm --interface) they don't. The long form just displays the help menu instead of proper output. The displayed help screen does show the long form as a valid command.
Version-Release number of selected component (if applicable):
enter any fcoeadm command in both short form and long form, observe differences.
Help is displayed for the long form rather then output expected for the flag.
The output should be the same for both short and long forms of the fcoeadm options.
The fcoeadm --help, --stats and --version commands do function as expected, the rest give nothing but the help screen.
I'm working on patch. Could you please tell me, if you are experiencing problems with --lun parameter? It looks fine to me.
Yes, the "fcoeadm --lun ..." form of the command does appear to work exactly as teh "fcoeadm -l ..." form. I did see the help screen rather then LUN info when I was trying this earlier, but after examining my history buffer I realize I was using improper syntax.
Created attachment 342624 [details]
Patch fixes handling of long options given to fcoeadm
I've made attached patch. Before I commit it to rawhide, I want open-fcoe guys to take look at it and accept it to upstream version.
Jan, could you please mail this patch to firstname.lastname@example.org so the list can review it? That would also allow us to get a propper commit message and you can have your Signed-off line in the commit.
FYI: I took a quick glance at the change and it looks good. I have not tested it though.
For now, I've applied the patch, it should work fine. If there are any issues with it, please open new bugzilla. In the future I expect complete rework of option handling. Rebase of the package will probably take place after that.