Bug 498703 (perl-Term-Completion) - Review Request: perl-Term-Completion - Read one line of user input, with convenience functions
Summary: Review Request: perl-Term-Completion - Read one line of user input, with conv...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Term-Completion
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Term-Comp...
Whiteboard:
Depends On:
Blocks: 484485
TreeView+ depends on / blocked
 
Reported: 2009-05-02 06:59 UTC by Chris Weyl
Modified: 2009-05-04 22:43 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-05-04 22:43:32 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2009-05-02 06:59:35 UTC
Spec URL: http://fedorapeople.org/~cweyl/review/perl-Term-Completion.spec
SRPM URL: http://fedorapeople.org/~cweyl/review/perl-Term-Completion-0.91-1.fc10.src.rpm

Description:
Term::Completion is an extensible, highly configurable replacement for
the venerable Term::Complete package. It is object-oriented and thus allows
subclassing. Two derived classes are Term::Completion::Multi and
Term::Completion::Path. A prompt is printed and the user may enter one line
of input, submitting the answer by pressing the ENTER key.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1332443

*rt-0.10

Comment 1 Parag AN(पराग) 2009-05-03 15:48:35 UTC
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1332443
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6f5920facb98b20923559f57608bb6ef  Term-Completion-0.91.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=9, Tests=100,  1 wallclock secs ( 0.09 usr  0.02 sys +  0.70 cusr  0.08 csys =  0.89 CPU)

+ Package perl-Term-Completion-0.91-1.fc12.noarch =>
Provides: perl(Term::Completion) = 0.91 perl(Term::Completion::Multi) = 0.90 perl(Term::Completion::Path) = 0.90 perl(Term::Completion::_POSIX) perl(Term::Completion::_readkey) perl(Term::Completion::_stty) perl(Term::Completion::_termsize)
Requires: perl(Carp) perl(Exporter) perl(File::Spec) perl(IO::Handle) perl(POSIX) perl(Term::ReadKey) perl(base) perl(strict) perl(warnings)

 APPROVED.

Comment 2 Chris Weyl 2009-05-03 18:31:28 UTC
New Package CVS Request
=======================
Package Name: perl-Term-Completion
Short Description: Read one line of user input, with convenience functions
Owners: cweyl
Branches: F-9 F-10 F-11 devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-05-04 03:52:16 UTC
cvs done.

Comment 4 Chris Weyl 2009-05-04 22:43:32 UTC
Thanks for the review! :-)


Note You need to log in before you can comment on or make changes to this bug.