Spec URL: http://jbowes.fedorapeople.org/rpms/gitg.spec SRPM URL: http://jbowes.fedorapeople.org/rpms/gitg-0.0.3-1.fc11.src.rpm Description: gitg is a GitX clone for GNOME/gtk+. It aims at being a small, fast and convenient tool to visualize git history and actions that benefit from a graphical presentation.
- You don't need a vendor tag to build, and if you do it should be empty: --vendor="" according to the policy. - Package does not build in mock, at least dbus-devel is missing. - The build might also fail on schema installation, which you may need to disable: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
Once you have fixed the mock build issue I will review the package.
Updated: Spec URL: http://jbowes.fedorapeople.org/rpms/gitg.spec SRPM URL: http://jbowes.fedorapeople.org/rpms/gitg-0.0.3-1.fc10.src.rpm Thanks for the feedback, Jussi. The package now builds in mock under f10 and rawhide. I think the vendor and gconf bits are cleaned up, too.
rpmlint output: gitg.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gitg.schemas 3 packages and 0 specfiles checked; 0 errors, 1 warnings. - The same kind of warnings seem to be made by also other packages that have gconf schemas so this is probably OK to ignore. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. NEEDSFIX - No mixing of %{buildroot} and RPM_BUILD_ROOT! MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. OK MUST: Optflags are used and time stamps preserved. NEEDSFIX - Time stamps are not preserved, add INSTALL="install -p" as argument to make install. MUST: Packages containing shared library files must call ldconfig. N/A MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSFIX - Add ChangeLog to %doc. MUST: Header files must be in a -devel package. N/A MUST: Static libraries must be in a -static package. N/A MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A MUST: If a package contains library files with a suffix then library files ending in .so must go in a -devel package. N/A MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. N/A MUST: Packages does not contain any .la libtool archives. N/A MUST: Desktop files are installed properly. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK
Updated: Spec URL: http://jbowes.fedorapeople.org/rpms/gitg.spec SRPM URL: http://jbowes.fedorapeople.org/rpms/gitg-0.0.3-1.fc10.src.rpm - %{buildroot} changed to $RPM_BUILD_ROOT - ChangeLog added to %doc - INSTALL="install -p" used for make install
Even though you didn't increment the release tag as you should have, the package has been APPROVED.
Thanks for the review, Jussi!
New Package CVS Request ======================= Package Name: gitg Short Description: GTK+ graphical interface for the git revision control system Owners: jbowes Branches: F10 F11 InitialCC:
cvs done.