Spec URL: http://fedorapeople.org/~iarnell/review/perl-Data-FormValidator-Constraints-DateTime.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc12.src.rpm Description: This package provides constraint routines for Data::FormValidator for dealing with dates and times. It provides an easy mechanism for validating dates of any format (using strptime(3)) and transforming those dates (as long as you 'untaint' the fields) into valid DateTime objects, or into strings that would be properly formatted for various database engines. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334715 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334715 + rpmlint is silent for SRPM and for RPM. + source files match upstream url adec700adf05d817e09e890d99d9a339 Data-FormValidator-Constraints-DateTime-1.09.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=292, 2 wallclock secs ( 0.02 usr 0.03 sys + 1.98 cusr 0.19 csys = 2.22 CPU) + Package perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc12.noarch => Provides: perl(Data::FormValidator::Constraints::DateTime) = 1.09 Requires: perl(Carp) perl(DateTime) perl(DateTime::Format::Strptime) perl(Exporter) perl(Scalar::Util) perl(strict) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Data-FormValidator-Constraints-DateTime Short Description: D::FV constraints for dates and times Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc11
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc10
Thanks for the review! :-)
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.