Bug 498866 - Review Request: perl-Data-FormValidator-Constraints-DateTime - D::FV constraints for dates and times
Summary: Review Request: perl-Data-FormValidator-Constraints-DateTime - D::FV constrai...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Data-Form...
Depends On:
TreeView+ depends on / blocked
Reported: 2009-05-04 06:42 UTC by Iain Arnell
Modified: 2009-05-14 02:55 UTC (History)
3 users (show)

Fixed In Version: 1.09-1.fc10
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-05-04 23:35:09 UTC
Type: ---
panemade: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Iain Arnell 2009-05-04 06:42:04 UTC
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Data-FormValidator-Constraints-DateTime.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc12.src.rpm

This package provides constraint routines for Data::FormValidator for
dealing with dates and times. It provides an easy mechanism for validating
dates of any format (using strptime(3)) and transforming those dates (as
long as you 'untaint' the fields) into valid DateTime objects, or into
strings that would be properly formatted for various database engines.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334715


Comment 1 Parag AN(पराग) 2009-05-04 07:23:16 UTC
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334715
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
adec700adf05d817e09e890d99d9a339  Data-FormValidator-Constraints-DateTime-1.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=292,  2 wallclock secs ( 0.02 usr  0.03 sys +  1.98 cusr  0.19 csys =  2.22 CPU)
+ Package perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc12.noarch =>
Provides: perl(Data::FormValidator::Constraints::DateTime) = 1.09
Requires: perl(Carp) perl(DateTime) perl(DateTime::Format::Strptime) perl(Exporter) perl(Scalar::Util) perl(strict)
+ Not a GUI application


Comment 2 Iain Arnell 2009-05-04 09:35:57 UTC
New Package CVS Request
Package Name: perl-Data-FormValidator-Constraints-DateTime
Short Description: D::FV constraints for dates and times
Owners: iarnell
Branches: F-10 F-11
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2009-05-04 20:47:19 UTC
cvs done.

Comment 4 Fedora Update System 2009-05-04 23:28:41 UTC
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc11 has been submitted as an update for Fedora 11.

Comment 5 Fedora Update System 2009-05-04 23:28:46 UTC
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc10 has been submitted as an update for Fedora 10.

Comment 6 Iain Arnell 2009-05-04 23:35:09 UTC
Thanks for the review! :-)

Comment 7 Fedora Update System 2009-05-14 02:54:07 UTC
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2009-05-14 02:55:35 UTC
perl-Data-FormValidator-Constraints-DateTime-1.09-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.