Spec URL: http://fedorapeople.org/~iarnell/review/perl-Class-Mix.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Class-Mix-0.002-1.fc12.src.rpm Description: The mix_class function provided by this module dynamically generates 'anonymous' classes with specified inheritance. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334916 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334916 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7773c6342f20370c4b40d468da031016 Class-Mix-0.002.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=17, 1 wallclock secs ( 0.05 usr 0.02 sys + 0.27 cusr 0.05 csys = 0.39 CPU) + Package perl-Class-Mix-0.002-1.fc12.noarch => Provides: perl(Class::Mix) = 0.002 Requires: perl(Carp) perl(base) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Class-Mix Short Description: Dynamic class mixing Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Class-Mix-0.002-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Class-Mix-0.002-1.fc11
perl-Class-Mix-0.002-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Class-Mix-0.002-1.fc10
Thanks for the review! :-)
perl-Class-Mix-0.002-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Class-Mix-0.002-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Class-Mix New Branches: el6 Owners: iarnell InitialCC: perl-sig
Git done (by process-git-requests).
Package Change Request ====================== Package Name: perl-Class-Mix New Branches: epel7 Owners: psabata InitialCC: perl-sig
Thanks again.