Spec URL: http://fedorapeople.org/~iarnell/review/perl-Module-Pluggable-Ordered.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Module-Pluggable-Ordered-1.5-1.fc12.src.rpm Description: This module behaves exactly the same as Module::Pluggable, supporting all of its options, but also mixes in the call_plugins and plugins_ordered methods to your class. call_plugins acts a little like Class::Trigger; it takes the name of a method, and some parameters. Let's say we call it like so: Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334978 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334978 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a9a33859fa3ff61a845035d44a2f73e8 Module-Pluggable-Ordered-1.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=11, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.22 cusr 0.02 csys = 0.28 CPU) + Package perl-Module-Pluggable-Ordered-1.5-1.fc12.noarch => Provides: perl(Module::Pluggable::Ordered) = 1.5 Requires: perl(Module::Pluggable) perl(UNIVERSAL::require) perl(strict) perl(vars) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Module-Pluggable-Ordered Short Description: Call module plugins in a specified order Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Module-Pluggable-Ordered-1.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Module-Pluggable-Ordered-1.5-1.fc11
perl-Module-Pluggable-Ordered-1.5-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Module-Pluggable-Ordered-1.5-1.fc10
Thanks for the review! :-)
perl-Module-Pluggable-Ordered-1.5-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Module-Pluggable-Ordered-1.5-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.