Bug 498897 - Review Request: perl-Module-Pluggable-Ordered - Call module plugins in a specified order
Review Request: perl-Module-Pluggable-Ordered - Call module plugins in a spec...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/Module-Pl...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-04 06:21 EDT by Iain Arnell
Modified: 2009-05-13 22:57 EDT (History)
3 users (show)

See Also:
Fixed In Version: 1.5-1.fc11
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-05-04 19:35:16 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Iain Arnell 2009-05-04 06:21:16 EDT
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Module-Pluggable-Ordered.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Module-Pluggable-Ordered-1.5-1.fc12.src.rpm

Description:
This module behaves exactly the same as Module::Pluggable, supporting
all of its options, but also mixes in the call_plugins and
plugins_ordered methods to your class. call_plugins acts a little like
Class::Trigger; it takes the name of a method, and some parameters.
Let's say we call it like so:

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334978

*rt-0.09
Comment 1 Parag AN(पराग) 2009-05-04 07:04:17 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334978
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
a9a33859fa3ff61a845035d44a2f73e8  Module-Pluggable-Ordered-1.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=11,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.22 cusr  0.02 csys =  0.28 CPU)
+ Package perl-Module-Pluggable-Ordered-1.5-1.fc12.noarch =>
Provides: perl(Module::Pluggable::Ordered) = 1.5
Requires: perl(Module::Pluggable) perl(UNIVERSAL::require) perl(strict) perl(vars)
+ Not a GUI application

APPROVED.
Comment 2 Iain Arnell 2009-05-04 07:19:47 EDT
New Package CVS Request
=======================
Package Name: perl-Module-Pluggable-Ordered
Short Description: Call module plugins in a specified order
Owners: iarnell
Branches: F-10 F-11
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-05-04 16:49:53 EDT
cvs done.
Comment 4 Fedora Update System 2009-05-04 19:30:14 EDT
perl-Module-Pluggable-Ordered-1.5-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Module-Pluggable-Ordered-1.5-1.fc11
Comment 5 Fedora Update System 2009-05-04 19:30:19 EDT
perl-Module-Pluggable-Ordered-1.5-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Module-Pluggable-Ordered-1.5-1.fc10
Comment 6 Iain Arnell 2009-05-04 19:35:16 EDT
Thanks for the review! :-)
Comment 7 Fedora Update System 2009-05-13 22:53:30 EDT
perl-Module-Pluggable-Ordered-1.5-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2009-05-13 22:57:19 EDT
perl-Module-Pluggable-Ordered-1.5-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.