Bug 499019 - CRM 1908390 - BUG: warning at fs/inotify.c:181/set_dentry_child_flags()
CRM 1908390 - BUG: warning at fs/inotify.c:181/set_dentry_child_flags()
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
5.2
All Linux
urgent Severity medium
: rc
: ---
Assigned To: Danny Feng
Red Hat Kernel QE team
: OtherQA, ZStream
: 520556 526853 545125 (view as bug list)
Depends On:
Blocks: 533192 525215 526775 533822 568662 568663
  Show dependency treegraph
 
Reported: 2009-05-04 16:20 EDT by Issue Tracker
Modified: 2010-10-26 10:25 EDT (History)
17 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-03-30 02:51:28 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
rhel5-158.el5 - inotify: fix race (2.08 KB, patch)
2009-07-14 17:36 EDT, Flavio Leitner
no flags Details | Diff
rhel5-158.el5 - inotify: remove debug code (2.47 KB, patch)
2009-07-14 17:39 EDT, Flavio Leitner
no flags Details | Diff

  None (edit)
Description Issue Tracker 2009-05-04 16:20:46 EDT
Escalated to Bugzilla from IssueTracker
Comment 9 Flavio Leitner 2009-07-14 17:36:09 EDT
Created attachment 351700 [details]
rhel5-158.el5 - inotify: fix race
Comment 10 Flavio Leitner 2009-07-14 17:39:40 EDT
Created attachment 351701 [details]
rhel5-158.el5 - inotify: remove debug code
Comment 14 Harshula Jayasuriya 2009-09-17 23:06:02 EDT
*** Bug 520556 has been marked as a duplicate of this bug. ***
Comment 15 RHEL Product and Program Management 2009-10-01 12:16:02 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 18 Eric Paris 2009-10-19 10:56:08 EDT
*** Bug 526853 has been marked as a duplicate of this bug. ***
Comment 21 Chris Ward 2009-10-20 04:06:21 EDT
We need to confirm that there is commitment to test 
for the resolution of this request during the RHEL 5.5 Test
Phase, if it is accepted into the release. 

Please post a confirmation before Oct 23rd, 2009, 
including the contact information for testing engineers.
Comment 27 Flavio Leitner 2009-10-26 12:27:19 EDT
Description of problem:

Customer has reported that the following messages in his production box. 

Mar 31 17:51:13 kernel: 
BUG: warning at fs/inotify.c:181/set_dentry_child_flags() (Tainted: PF    )
Call Trace:
 [<ffffffff800ed831>] set_dentry_child_flags+0xef/0x14d
 [<ffffffff800ed8c7>] remove_watch_no_event+0x38/0x47
 [<ffffffff800ed8ee>] inotify_remove_watch_locked+0x18/0x3b
 [<ffffffff800ed9dc>] inotify_rm_wd+0x7e/0xa1
 [<ffffffff800edece>] sys_inotify_rm_watch+0x46/0x63
 [<ffffffff8005d116>] system_call+0x7e/0x83

BUG: warning at fs/inotify.c:181/set_dentry_child_flags() (Tainted: PF    )
Call Trace:
 [<ffffffff800ed831>] set_dentry_child_flags+0xef/0x14d
 [<ffffffff800ed8c7>] remove_watch_no_event+0x38/0x47
 [<ffffffff800ed8ee>] inotify_remove_watch_locked+0x18/0x3b
 [<ffffffff800ed9dc>] inotify_rm_wd+0x7e/0xa1
 [<ffffffff800edece>] sys_inotify_rm_watch+0x46/0x63
 [<ffffffff8005d116>] system_call+0x7e/0x83

BUG: warning at fs/inotify.c:181/set_dentry_child_flags() (Tainted: PF    )
Call Trace:
 [<ffffffff800ed831>] set_dentry_child_flags+0xef/0x14d
 [<ffffffff800ed8c7>] remove_watch_no_event+0x38/0x47
 [<ffffffff800ed8ee>] inotify_remove_watch_locked+0x18/0x3b
 [<ffffffff800ed9dc>] inotify_rm_wd+0x7e/0xa1
 [<ffffffff800edece>] sys_inotify_rm_watch+0x46/0x63
 [<ffffffff8005d116>] system_call+0x7e/0x83

current Kernel: 2.6.18-92.1.13.el5

cat proc/cpuinfo | grep processor | wc -l
16

Soon after these messages, syslog shows:
Mar 31 17:57:05 kernel: BUG: soft lockup - CPU#9 stuck for 10s! [java:9250]
Mar 31 17:57:09 kernel: BUG: soft lockup - CPU#8 stuck for 10s! [java:9245]
Mar 31 17:57:10 kernel: BUG: soft lockup - CPU#3 stuck for 10s! [snmpd:6501]
Mar 31 17:57:11 kernel: BUG: soft lockup - CPU#7 stuck for 10s! [perl:15683]
Mar 31 17:57:12 kernel: BUG: soft lockup - CPU#1 stuck for 10s! [vsftpd:15764]

From SAR of March31, Load average on the system is on the higher side. 
This could be reason for unresponsiveness

Following upstream patch seems to address the issue
http://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/broken-out/inotify-fix-race.patch

Upstream patch from kernel bug 8938 seems to fit in cleanly with RHEL 5. 
http://bugzilla.kernel.org/show_bug.cgi?id=8938

How reproducible:
not known

Steps to Reproduce:
Not known

Actual results:
inotify race is seen

Expected results:
inotify race needs to be fixed
Comment 28 Don Zickus 2009-10-28 16:17:23 EDT
in kernel-2.6.18-171.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please do NOT transition this bugzilla state to VERIFIED until our QE team
has sent specific instructions indicating when to do so.  However feel free
to provide a comment indicating that this fix has been verified.
Comment 32 Sotiris Tsimbonis 2009-11-03 02:40:01 EST
Installed kernel-2.6.18-171.el5 since 29 Oct, no sign of the message so far (it was quite frequent before)..
Comment 36 Frederik Ferner 2009-11-10 09:07:10 EST
Same here, we've not seen any of the soft lockups or inotify warnings since we've installed the test kernel on Nov 3 on the machine where we've had soft lockups many times per day.
Comment 47 errata-xmlrpc 2010-03-30 02:51:28 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html
Comment 51 Josef Bacik 2010-09-09 12:56:33 EDT
*** Bug 545125 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.