Spec URL: http://fedorapeople.org/~iarnell/review/perl-Locale-PO.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Locale-PO-0.21-1.fc12.src.rpm Description: This module simplifies management of GNU gettext .po files and is an alternative to using emacs po-mode. It provides an object-oriented interface in which each entry in a .po file is a Locale::PO object. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1336384 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1336384 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2cb9a5f472e944685c43588e18f24fcb6101de47 Locale-PO-0.21.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=30, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.15 cusr 0.03 csys = 0.19 CPU) + Package perl-Locale-PO-0.21-1.fc12.noarch => Provides: perl(Locale::PO) = 0.21 Requires: perl(Carp) perl(strict) perl(warnings) + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-Locale-PO Short Description: Perl module for manipulating .po entries from GNU gettext Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Locale-PO-0.21-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Locale-PO-0.21-1.fc11
perl-Locale-PO-0.21-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Locale-PO-0.21-1.fc10
Thanks for the review! :-)
perl-Locale-PO-0.21-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Locale-PO-0.21-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Package Change Request ====================== Package Name: perl-Locale-PO New Branches: EL-5 EL-6 Owners: iarnell rlandmann InitialCC: perl-sig Note that perl-Locale-PO is currently in EL6 optional, but not for all archs.
CVS done (by process-cvs-requests.py). Make sure and build the exact same version thats in RHEL.