Bug 499148 - cert.h doesn't have valid functions prototypes
Summary: cert.h doesn't have valid functions prototypes
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: nss
Version: 5.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Kai Engert (:kaie) (inactive account)
QA Contact: BaseOS QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-05 12:07 UTC by Jan Friesse
Modified: 2009-05-07 20:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-07 20:01:37 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Patch fixing this problem (1.09 KB, patch)
2009-05-05 12:07 UTC, Jan Friesse
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Mozilla Foundation 491919 0 None None None Never

Description Jan Friesse 2009-05-05 12:07:08 UTC
Created attachment 342444 [details]
Patch fixing this problem

Description of problem:
cert.h doesn't have valid function prototypes. For example CERT_GetPKIXVerifyNistRevocationPolicy() should be CERT_GetPKIXVerifyNistRevocationPolicy(void). Attached patch will say you more.

Version-Release number of selected component (if applicable):
nss-devel-3.12.2.0-4.el5

How reproducible:
always

Steps to Reproduce:
1. write main.c with
#include <cert.h>

int main(void) {
  return 0;
}

2.

gcc `pkg-config --libs --cflags nss` -Wstrict-prototypes main.c

  
Actual results:
/usr/include/nss3/cert.h:1608: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1614: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1620: warning: function declaration isn’t a prototype
/usr/include/nss3/cert.h:1654: warning: function declaration isn’t a prototype

Expected results:
No warnings displayed

Additional info:
Patch included.

Comment 1 Kai Engert (:kaie) (inactive account) 2009-05-07 20:01:37 UTC
Thanks for the report.

Bug forwarded to upstream:
https://bugzilla.mozilla.org/show_bug.cgi?id=491919

I assume you can wait until upstream fixes this warning.
Closing as upstream.


Note You need to log in before you can comment on or make changes to this bug.