Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://oget.fedorapeople.org/review/meterbridge.spec SRPM URL: http://oget.fedorapeople.org/review/meterbridge-0.9.2-3.fc10.src.rpm Description: %{name} is a software meter bridge is for the UNIX based JACK audio system. It supports a number of different types of meter, rendered using the SDL library and user-editable pixmaps. rpmlint is silent koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1338073
Sorry, the description is: %{name} is a software meter bridge for the UNIX based JACK audio system. It supports a number of different types of meter, rendered using the SDL library and user-editable pixmaps.
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1338073 + rpmlint is silent for SRPM and for RPM. + source files match upstream url cf683c623b12342a951f541c9e674cd162a9ad91 meterbridge-0.9.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package meterbridge-0.9.2-3.fc12.i586 => Requires: libSDL-1.2.so.0 libSDL_image-1.2.so.0 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libjack.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libm.so.6(GLIBC_2.1) libpthread.so.0 librt.so.1 rtld(GNU_HASH) Provides: meterbridge = 0.9.2-3.fc10 + Not a GUI application suggestions: 1) should ask upstream to add contents to README. 2) License tag should be GPLv2+ APPROVED.
(In reply to comment #2) > Review: Thank you for the review Parag! > suggestions: > 1) should ask upstream to add contents to README. I'll do that. > 2) License tag should be GPLv2+ The source files do not specify the version of GPL in their headers. In this case we choose GPL+ as per the guidelines. Please see instrcution #4 at https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F Do I miss something? New Package CVS Request ======================= Package Name: meterbridge Short Description: Meter Bridge for JACK Owners: oget Branches: F-9 F-10 F-11 InitialCC:
cvs done.
meterbridge-0.9.2-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/meterbridge-0.9.2-3.fc11
meterbridge-0.9.2-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/meterbridge-0.9.2-3.fc10
meterbridge-0.9.2-3.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/meterbridge-0.9.2-3.fc9
yes you are correct. make it GPL+.
meterbridge-0.9.2-3.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
meterbridge-0.9.2-3.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
meterbridge-0.9.2-3.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.