Bug 499386 - libvirt's qemu driver interprets the <hostdev> "managed" attribute incorrectly
Summary: libvirt's qemu driver interprets the <hostdev> "managed" attribute incorrectly
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libvirt
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mark McLoughlin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F11VirtTarget
TreeView+ depends on / blocked
 
Reported: 2009-05-06 13:46 UTC by Mark McLoughlin
Modified: 2009-05-06 21:37 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 499577 (view as bug list)
Environment:
Last Closed: 2009-05-06 21:37:37 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mark McLoughlin 2009-05-06 13:46:47 UTC
When using virt-install --host-device, the device XML looks like this:

    <hostdev mode='subsystem' type='pci' managed='yes'>
      <source>
        <address domain='0' bus='0' slot='25' function='0'/>
      </source>
    </hostdev>

With managed='yes', libvirt doesn't detach or reset the device before starting the guest, nor does it it re-attach it when the guest is shut down.

AFAICS, this is just a typo and we actually want "managed='no'"

Comment 1 Mark McLoughlin 2009-05-06 13:59:13 UTC
Okay, it turns out "managed='yes'" is supposed to detach/reset/reattach the device, not "managed='no'"

The fix should be as simple as:

@@ -1215,7 +1215,7 @@ static int qemuPrepareHostDevices(virConnectPtr conn,
         if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
             continue;
 
-        if (!hostdev->managed) {
+        if (hostdev->managed) {
             pciDevice *dev = pciGetDevice(conn,
                                           hostdev->source.subsys.u.pci.domain,
                                           hostdev->source.subsys.u.pci.bus,

Comment 2 Mark McLoughlin 2009-05-06 15:41:12 UTC
Patch posted to libvir-list:

  http://www.redhat.com/archives/libvir-list/2009-May/msg00111.html

Comment 3 Cole Robinson 2009-05-06 16:37:38 UTC
Being built into libvirt-0.6.2-6.fc11 atm.

Comment 4 Mark McLoughlin 2009-05-06 20:17:32 UTC
Tag request: https://fedorahosted.org/rel-eng/ticket/1748

* Wed May  6 2009 Mark McLoughlin <markmc> - 0.6.2-5.fc11
- Fix handling of <hostdev managed='yes'> (bug #499386)

Comment 5 Mark McLoughlin 2009-05-06 21:37:37 UTC
Tagged now


Note You need to log in before you can comment on or make changes to this bug.