Bug 499469 - Review Request: libtalloc - spin off of samba4 package
Summary: Review Request: libtalloc - spin off of samba4 package
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthew Barnes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-06 19:03 UTC by Simo Sorce
Modified: 2010-03-16 19:35 UTC (History)
4 users (show)

Fixed In Version: libtalloc-2.0.1-1.el5
Clone Of:
Environment:
Last Closed: 2009-06-19 16:50:32 UTC
Type: ---
Embargoed:
mbarnes: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Simo Sorce 2009-05-06 19:03:15 UTC
Spec URL: http://simo.fedorapeople.org/libtalloc/libtalloc.spec
SRPM URL: http://simo.fedorapeople.org/libtalloc/libtalloc-1.3.0-0.fc11.src.rpm
Description: Spin off libtalloc from the samba4 package into its own now that upstream has finally released a separate tarball.
The package name and versioning is consistent with what was provided by the samba4 package so dropping this in and disabling building "talloc" from the samba4 package should provide a seamless migration path

Comment 1 Matthew Barnes 2009-05-08 18:03:13 UTC
rpmlint output:

libtalloc.i586: I: checking
libtalloc.i586: E: no-ldconfig-symlink /usr/lib/libtalloc.so.1.3.0
libtalloc.i586: W: shared-lib-calls-exit /usr/lib/libtalloc.so.1.3.0 exit
libtalloc.i586: W: no-documentation
libtalloc.i586: W: one-line-command-in-%post /sbin/ldconfig
libtalloc.i586: W: one-line-command-in-%postun /sbin/ldconfig
libtalloc-debuginfo.i586: I: checking
libtalloc-devel.i586: I: checking

libtalloc.src: I: checking
libtalloc.src:53: E: files-attr-not-set
libtalloc.src:54: E: files-attr-not-set
libtalloc.src:55: E: files-attr-not-set
libtalloc.src:56: E: files-attr-not-set
libtalloc.src:58: E: files-attr-not-set
libtalloc.src:59: E: files-attr-not-set
libtalloc.src:61: E: files-attr-not-set
libtalloc.src:62: E: files-attr-not-set

Issues to resolve:

- Missing Requires: pkgconfig.
- devel files are missing a %defattr.

Comment 2 Simo Sorce 2009-05-08 23:01:00 UTC
Fixed symlink
Fixed Requires
Fixed %defattr

Unless Warnings are critical it should be fine now.

Comment 3 Matthew Barnes 2009-05-09 02:36:57 UTC
Nah, the warnings can be ignored.  Approved.

Comment 4 Simo Sorce 2009-05-09 14:20:09 UTC
New Package CVS Request
=======================
Package Name: libtalloc
Short Description: A library that implements a hierarchical memory allocator.
Owners: simo gd
Branches: F11
InitialCC:

Comment 5 Kevin Fenzi 2009-05-09 21:04:26 UTC
cvs done.

Comment 6 Matthew Barnes 2009-06-19 16:50:32 UTC
Closing this.

Comment 7 Stephen Gallagher 2010-02-23 19:00:41 UTC
Package Change Request
======================
Package Name: libtalloc
New Branches: EL-5
Owners: sgallagh

This is being branched in preparation for building the SSSD in EPEL. (libtalloc is
a dependency)

I have simo's permission to become the EPEL maintainer for this package.

Comment 8 Jason Tibbitts 2010-02-23 20:01:44 UTC
CVS done.

Comment 9 Fedora Update System 2010-02-23 20:31:11 UTC
libtalloc-2.0.1-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/libtalloc-2.0.1-1.el5

Comment 10 Fedora Update System 2010-03-16 19:35:26 UTC
libtalloc-2.0.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.