Red Hat Bugzilla – Bug 499669
libvirt QEMU driver is using old pci_add/pci_del syntax
Last modified: 2009-08-15 04:30:28 EDT
Description of problem:
Hot-removing a virtio-blk device succeeds even if the guest did not remove
it, because device was in use.
Version-Release number of selected component (if applicable):
Fedora 11 Preview
Steps to Reproduce:
1. Add a virtio-blk device
2. Mount it on the guest, grab a reference to the device
3. Hot remove it in virt-manager
The icon for the disk disappears in virt-manager, even though the guest
did not successfully removed it. Perhaps its not checking the return value from
pci_del properly? Or pci_del response is wrong for some reason.
Should display "cannot remove device from guest", which does happen if you attempt to remove for example vda where the guest root filesystem is mounted.
Hum, maybe this is not a virt-manager fault. The device is dead on the guest (trying to umount it hangs forever). But the pci device is there, so the guest did not ack the ACPI removal event.
Actually, it was working with kvm-74 installed. After the upgrade to the new
qemu packages in FC11 PCI hot-add broke:
pci_add 0 storage file=/tmp/file10,if=scsi
Invalid pci address^
Which is the old syntax for pci_add.
(In reply to comment #2)
> Actually, it was working with kvm-74 installed. After the upgrade to the new
> qemu packages in FC11 PCI hot-add broke:
> pci_add 0 storage file=/tmp/file10,if=scsi
> Invalid pci address^
> info balloon
> Which is the old syntax for pci_add.
This sounds like a different bug - could you file it separately? Sounds like libvirt needs code for the new syntax
I'll retest the original issue once virt-manager is talking the new syntax,
and open a new bug in case its still problematic.
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.
More information and reason for this action is here:
Author: Daniel P. Berrange <firstname.lastname@example.org>
Date: Mon Jul 6 15:58:55 2009 +0100
Fix PCI device hotplug/unplug with newer QEMU
* src/qemu_driver.c: Try new monitor syntax for hotplug first. If
that fails fallback to old KVM specific syntax
Built fix into libvirt-0.6.2-14.fc11
libvirt-0.6.2-14.fc11 has been submitted as an update for Fedora 11.
libvirt-0.6.2-14.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
su -c 'yum --enablerepo=updates-testing update libvirt'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8333
libvirt-0.6.2-14.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.