Spec URL: http://oget.fedorapeople.org/review/jack-keyboard.spec SRPM URL: http://oget.fedorapeople.org/review/jack-keyboard-2.5-1.fc10.src.rpm Description: jack-keyboard is a virtual MIDI keyboard - a program that allows you to send JACK MIDI events using your PC keyboard. It's somewhat similar to vkeybd, except it uses JACK MIDI instead of ALSA, and the default keyboard mapping is much better - it uses the same layout as trackers (like Impulse Tracker) did, so you have two and half octaves under your fingers. rpmlint is silent. koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1341298
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1341298 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 030a666f1703ef1ab3eae6004cb04a9a jack-keyboard-2.5.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + Icon Cache scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed correctly. Suggestions: 1) change Generic name to GenericName=Virtual MIDI Keyboard" 2) you can add Requires: hicolor-icon-theme APPROVED.
Again, Thank you for the review Parag! Also thanks for the suggestions. I will do that change on the GenericName. The hicolor-icon-theme dependency is satisfied through gtk2 and it won't break. I'd like to keep things minimal. New Package CVS Request ======================= Package Name: jack-keyboard Short Description: Virtual keyboard for JACK MIDI Owners: oget Branches: F-9 F-10 F-11 InitialCC:
cvs done.
jack-keyboard-2.5-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jack-keyboard-2.5-2.fc11
jack-keyboard-2.5-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/jack-keyboard-2.5-2.fc10
jack-keyboard-2.5-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/jack-keyboard-2.5-2.fc9
jack-keyboard-2.5-2.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jack-keyboard'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4718
jack-keyboard-2.5-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jack-keyboard'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4744
jack-keyboard-2.5-2.fc9 has been pushed to the Fedora 9 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing-newkey update jack-keyboard'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2009-4854
jack-keyboard-2.5-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
jack-keyboard-2.5-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
jack-keyboard-2.5-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.