Bug 499816 - bad handle umask in pam_mkhomedir
Summary: bad handle umask in pam_mkhomedir
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: pam
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Tomas Mraz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-08 11:55 UTC by Frantisek Hanzlik
Modified: 2009-12-27 20:33 UTC (History)
2 users (show)

Fixed In Version: 1.0.91-9.fc11
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-12-27 20:33:50 UTC


Attachments (Terms of Use)

Description Frantisek Hanzlik 2009-05-08 11:55:47 UTC
Description of problem:
Due to typing error in pam_mkhomedir.c is umask copied over skeldir,
see:

--- pam_mkhomedir.c.old	2009-03-03 14:56:01.000000000 +0100
+++ pam_mkhomedir.c	2009-05-08 13:40:53.000000000 +0200
@@ -84,7 +84,7 @@
       } else if (!strcmp(*argv, "debug")) {
          ctrl |= MKHOMEDIR_DEBUG;
       } else if (!strncmp(*argv,"umask=",6)) {
-	 strncpy(SkelDir,*argv+6,sizeof(UMask));
+	 strncpy(UMask,*argv+6,sizeof(UMask));
 	 UMask[sizeof(UMask)-1] = '\0';
       } else if (!strncmp(*argv,"skel=",5)) {
 	 strncpy(SkelDir,*argv+5,sizeof(SkelDir));

Version-Release number of selected component (if applicable):
pam-1.0.91-6.fc11 from 10-Apr-2009

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Bug Zapper 2009-06-09 15:26:59 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Tomas Mraz 2009-09-01 15:32:48 UTC
This is fixed in rawhide pam-1.1.0.

Comment 3 Fedora Update System 2009-11-02 12:48:15 UTC
pam-1.0.91-8.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pam-1.0.91-8.fc11

Comment 4 Fedora Update System 2009-11-04 12:11:30 UTC
pam-1.0.91-8.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pam'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-10922

Comment 5 Fedora Update System 2009-11-11 15:04:45 UTC
pam-1.0.91-8.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Gregory Lee Bartholomew 2009-12-07 22:44:12 UTC
I'm still experiencing this error with pam-1.0.91-8.fc11.x86_64.

[root@home ~]# rpm -q pam
pam-1.0.91-8.fc11.x86_64

[root@home ~]# tail /var/log/secure | grep mkhomedir_helper
Dec  7 16:39:53 home mkhomedir_helper: PAM unable to read directory 0077: No such file or directory

[root@home ~]# cat /etc/pam.d/sshd | grep pam_mkhomedir.so
session [default=ignore] pam_mkhomedir.so umask=0077

Comment 7 Tomas Mraz 2009-12-07 23:05:42 UTC
I'm sorry the patch was not properly applied.

Comment 8 Fedora Update System 2009-12-08 09:11:01 UTC
pam-1.0.91-9.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/pam-1.0.91-9.fc11

Comment 9 Fedora Update System 2009-12-10 04:31:28 UTC
pam-1.0.91-9.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update pam'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13037

Comment 10 Fedora Update System 2009-12-27 20:33:45 UTC
pam-1.0.91-9.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.