Spec URL: http://fedorapeople.org/~iarnell/review/perl-HTML-Defang.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-HTML-Defang-1.01-1.fc12.src.rpm Description: This module accepts an input HTML and/or CSS string and removes any executable code including scripting, embedded objects, applets, etc., and neutralises any XSS attacks. A whitelist based approach is used which means only HTML known to be safe is allowed through. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1346126 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1346126 + rpmlint is silent for SRPM and for RPM. + source files match upstream url cddcc61fd9dba2746267d54c96b5d2e52c72d705 HTML-Defang-1.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=559, 1 wallclock secs ( 0.17 usr 0.02 sys + 0.84 cusr 0.07 csys = 1.10 CPU) + Package perl-HTML-Defang-1.01-1.fc12.noarch => Provides: perl(HTML::Defang) Requires: perl(Encode) perl(Exporter) perl(bytes) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-HTML-Defang Short Description: Cleans HTML and CSS of executable contents Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-HTML-Defang-1.01-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-HTML-Defang-1.01-1.fc11
perl-HTML-Defang-1.01-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-HTML-Defang-1.01-1.fc10
Thanks for the review! :-)
perl-HTML-Defang-1.01-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-HTML-Defang-1.01-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.