Spec URL: http://fedorapeople.org/~iarnell/review/perl-XML-Atom.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-XML-Atom-0.35-1.fc12.src.rpm Description: Atom is a syndication, API, and archiving format for weblogs and other data. XML::Atom implements the feed format as well as a client for the API. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1346128 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1346128 + rpmlint is silent for SRPM and for RPM. + source files match upstream url aba19002bcfbc22f6e1ea7c5a0561bc04ef85740 XML-Atom-0.35.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=21, Tests=287, 4 wallclock secs ( 0.16 usr 0.05 sys + 4.24 cusr 0.41 csys = 4.86 CPU) + Package perl-XML-Atom-0.35-1.fc12.noarch => Provides: perl(LWP::UserAgent::AtomClient) perl(XML::Atom) = 0.35 perl(XML::Atom::Base) perl(XML::Atom::Category) perl(XML::Atom::Client) perl(XML::Atom::Content) perl(XML::Atom::Entry) perl(XML::Atom::ErrorHandler) perl(XML::Atom::Feed) perl(XML::Atom::Link) perl(XML::Atom::Namespace) perl(XML::Atom::Person) perl(XML::Atom::Server) perl(XML::Atom::Thing) perl(XML::Atom::Util) Requires: perl >= 0:5.008_001 perl(DateTime) perl(Digest::SHA1) perl(Encode) perl(Exporter) perl(LWP::UserAgent) perl(MIME::Base64) perl(Scalar::Util) perl(XML::Atom) perl(XML::Atom::Category) perl(XML::Atom::Content) perl(XML::Atom::Entry) perl(XML::Atom::Feed) perl(XML::Atom::Link) perl(XML::Atom::Person) perl(XML::Atom::Util) perl(base) perl(constant) perl(strict) perl(vars) suggestions: 1)do you really need following? BuildRequires: perl >= 1:5.8.1 APPROVED.
New Package CVS Request ======================= Package Name: perl-XML-Atom Short Description: Atom feed and API implementation Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-XML-Atom-0.35-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-XML-Atom-0.35-1.fc11
perl-XML-Atom-0.35-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-XML-Atom-0.35-1.fc10
Thanks for the review! :-)
perl-XML-Atom-0.35-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-XML-Atom-0.35-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.