Bug 500039 - (perl-Text-Emoticon) Review Request: perl-Text-Emoticon - Factory class for Yahoo! and MSN emoticons
Review Request: perl-Text-Emoticon - Factory class for Yahoo! and MSN emoticons
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/Text-Emot...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-05-10 07:09 EDT by Iain Arnell
Modified: 2009-05-19 20:54 EDT (History)
3 users (show)

See Also:
Fixed In Version: 0.04-1.fc10
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-05-10 23:32:56 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Iain Arnell 2009-05-10 07:09:23 EDT
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Text-Emoticon.spec
SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Text-Emoticon-0.04-1.fc12.src.rpm

Description:
Text::Emoticon is a factory class to dispatch MSN/YIM emoticon set.
It's made to become handy to be used in other applications like
Kwiki/MT plugins.

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1346132

*rt-0.09
Comment 1 Parag AN(पराग) 2009-05-10 12:01:23 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1346132
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c18cb2d67eec4b32752b05b6e30a12ca1fabb503  Text-Emoticon-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=3,  0 wallclock secs ( 0.05 usr  0.01 sys +  0.09 cusr  0.01 csys =  0.16 CPU)
+ Package perl-Text-Emoticon-0.04-1.fc12.noarch
Provides: perl(Text::Emoticon) = 0.04
Requires: perl(UNIVERSAL::require) perl(strict)

APPROVED.
Comment 2 Iain Arnell 2009-05-10 12:45:23 EDT
New Package CVS Request
=======================
Package Name: perl-Text-Emoticon
Short Description: Factory class for Yahoo! and MSN emoticons
Owners: iarnell
Branches: F-10 F-11
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-05-10 15:26:00 EDT
cvs done.
Comment 4 Fedora Update System 2009-05-10 23:20:18 EDT
perl-Text-Emoticon-0.04-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/perl-Text-Emoticon-0.04-1.fc11
Comment 5 Fedora Update System 2009-05-10 23:20:23 EDT
perl-Text-Emoticon-0.04-1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/perl-Text-Emoticon-0.04-1.fc10
Comment 6 Iain Arnell 2009-05-10 23:32:56 EDT
Thanks for the review! :-)
Comment 7 Fedora Update System 2009-05-19 20:52:06 EDT
perl-Text-Emoticon-0.04-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2009-05-19 20:53:59 EDT
perl-Text-Emoticon-0.04-1.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.