Spec URL: http://fedorapeople.org/~iarnell/review/perl-Text-Emoticon.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Text-Emoticon-0.04-1.fc12.src.rpm Description: Text::Emoticon is a factory class to dispatch MSN/YIM emoticon set. It's made to become handy to be used in other applications like Kwiki/MT plugins. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1346132 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1346132 + rpmlint is silent for SRPM and for RPM. + source files match upstream url c18cb2d67eec4b32752b05b6e30a12ca1fabb503 Text-Emoticon-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=3, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.09 cusr 0.01 csys = 0.16 CPU) + Package perl-Text-Emoticon-0.04-1.fc12.noarch Provides: perl(Text::Emoticon) = 0.04 Requires: perl(UNIVERSAL::require) perl(strict) APPROVED.
New Package CVS Request ======================= Package Name: perl-Text-Emoticon Short Description: Factory class for Yahoo! and MSN emoticons Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Text-Emoticon-0.04-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Text-Emoticon-0.04-1.fc11
perl-Text-Emoticon-0.04-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Text-Emoticon-0.04-1.fc10
Thanks for the review! :-)
perl-Text-Emoticon-0.04-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-Text-Emoticon-0.04-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.