Bug 500198 - Anaconda /proc/cmdline parsing during the installation is broken.
Summary: Anaconda /proc/cmdline parsing during the installation is broken.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: anaconda
Version: 5.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Will Woods
QA Contact: Release Test Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-11 16:06 UTC by Stanislav Polasek
Modified: 2018-11-14 19:59 UTC (History)
4 users (show)

Fixed In Version: anaconda-11.1.2.229-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-07-21 06:52:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2011:0984 0 normal SHIPPED_LIVE anaconda bug fix and enhancement update 2011-07-20 15:45:09 UTC

Description Stanislav Polasek 2009-05-11 16:06:12 UTC
Description of problem:
Anaconda /proc/cmdline parsing during the installation is broken.

Version-Release number of selected component (if applicable):
anaconda-11.1.2.168

How reproducible:
always

Steps to Reproduce:
1. Boot the installation media (boot.iso, virt-install kernel+initrd.img, install DVD)
2. Add some parameters at the boot: prompt line, use quotation marks (for example: ethtool="speed 100 duplex full autoneg off"
3. Continue the installation
4. Anaconda gets the stage2 and tracebacks

Actual results:
shlex.py booms with ValueError: "No closing quotation"

Expected results:
Installation without a problem.

Additional info:
Probably related to the bug 453212.

The code in flags.py is just wrong. It may solve pxe case, but it breaks other booting methods (see the lines 40-41):

 33     def createCmdlineDict(self):
 34         cmdlineDict = {}
 35         cmdline = open("/proc/cmdline", "r").read().strip()
 36 
 37         # if the BOOT_IMAGE contains a space, pxelinux will strip one of the
 38         # quotes leaving one at the end that shlex doesn't know what to do
 39         # with
 40         if cmdline.find("BOOT_IMAGE=") and cmdline.endswith('"'):
 41             cmdline = cmdline.replace("BOOT_IMAGE=", "BOOT_IMAGE=\"")
 42 
 43         lst = shlex.split(cmdline)
 44

Comment 3 RHEL Program Management 2011-03-11 22:39:24 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 David Cantrell 2011-03-22 16:11:01 UTC
qa_ack+ please?

Comment 6 Alexander Todorov 2011-05-10 12:52:44 UTC
Tested and verified with 0430.2 build. Booted from DVD with:
linux ethtool="speed 100 duplex full autoneg off"


There was no traceback.

Comment 7 errata-xmlrpc 2011-07-21 06:52:11 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0984.html


Note You need to log in before you can comment on or make changes to this bug.