Bug 500368
| Summary: | NETDEV_BONDING_FAILOVER is defined twice in the kernel | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Prarit Bhargava <prarit> |
| Component: | kernel | Assignee: | Andy Gospodarek <agospoda> |
| Status: | CLOSED ERRATA | QA Contact: | Red Hat Kernel QE team <kernel-qe> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.4 | CC: | agospoda, dledford, dzickus, gozen, imatusov, jpirko, mgahagan, peterm, syeghiay |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-02 08:14:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This needs to be fixed. In drivers/infiniband/include/linux/notifier.h we have this: #define NETDEV_BONDING_FAILOVER NETDEV_CHANGE and in include/linux/notifier.h we have this: #define NETDEV_BONDING_FAILOVER 0x000C and this: #define NETDEV_CHANGE 0x0004 The loud complaining is because NETDEV_BONDING_FAILOVER is set to two different values. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. I posted the fix for this already BTW. oh, ok. well I just posted it again. :-) http://post-office.corp.redhat.com/archives/rhkernel-list/2009-June/msg00508.html in kernel-2.6.18-154.el5 You can download this test kernel from http://people.redhat.com/dzickus/el5 Please do NOT transition this bugzilla state to VERIFIED until our QE team has sent specific instructions indicating when to do so. However feel free to provide a comment indicating that this fix has been verified. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2009-1243.html |
Description of problem: NETDEV_BONDING_FAILOVER is defined twice in the kernel. drivers/infiniband/include/linux/notifier.h the value is 0x000c include/linux/notifier.h the value is 0x0004 Version-Release number of selected component (if applicable): -146.el5 How reproducible: 100% Steps to Reproduce: 1. compile kernel source Actual results: The kernel build is *littered* with drivers/infiniband/include/linux/notifier.h:6:1: warning: "NETDEV_BONDING_FAILOVER" redefined In file included from drivers/infiniband/include/linux/notifier.h:4, from include/linux/memory_hotplug.h:7, from include/linux/mmzone.h:339, from include/linux/gfp.h:4, from include/linux/slab.h:14, from drivers/infiniband/include/linux/slab.h:1, from include/linux/percpu.h:4, from include/linux/rcupdate.h:41, from include/linux/pid.h:4, from include/linux/sched.h:71, from include/linux/module.h:9, from include/linux/device.h:19, from include/linux/dma-mapping.h:4, from drivers/infiniband/core/mad.c:35: include/linux/notifier.h:142:1: warning: this is the location of the previous definition Expected results: No errors should be seen. This appears to have been a collision between gospo's and dledford's near-simultaneous commits to network and infiniband code. Additional information: The bigger problem is that the infiniband code may be using an incorrect value for NETDEV_BONDING_FAILOVER. I haven't bothered to figure out what value it is using so I'm setting the priority higher on this BZ. Assigning to dledford. But it could also be gospo's bug too ...