Bug 500899
| Summary: | RFE: give better message when pvmove is already in progress on requested VG | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | Peter Rajnoha <prajnoha> |
| Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 5.3 | CC: | agk, coughlan, dwysocha, edamato, heinzm, jbrassow, mbroz, prajnoha, prockai |
| Target Milestone: | rc | Keywords: | FutureFeature |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | FailsQA | ||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 500898 | Environment: | |
| Last Closed: | 2010-03-30 09:02:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 500898 | ||
| Bug Blocks: | |||
|
Description
Corey Marthaler
2009-05-14 19:05:48 UTC
From Bug #500898: > Sure, I think we could change the message quite easily for that specific > situation (all PEs skipped on the PV because of the LV locks). So I will set devel_ack for 5.5. Peter, it is not a high priority, so change it if you will not have time. In lvm2-2_02_56-2_el5. I thought that we were going to remove the "No data to move for $vg" message because that's not true. There *is* data to move, but we can't move it due to another currently running pvmove process.
"All data on source PV skipped. It contains locked, hidden or non-top level LVs only."
Is that really the best we can do? We can't check for another running pvmove in that VG and state the obvious? Instead we give three possibilities that may be causing this cmd to fail?
[root@hayes-02 ~]# pvmove -v /dev/etherd/e1.1p2 /dev/etherd/e1.1p4
Finding volume group "ONE"
Executing: /sbin/modprobe dm-log-clustered
Archiving volume group "ONE" metadata (seqno 6).
Creating logical volume pvmove1
Skipping locked LV stripe
Skipping mirror LV pvmove0
All data on source PV skipped. It contains locked, hidden or non-top level LVs only.
No data to move for ONE
I kept the "No data to move" even if all LVs are skipped because it seemed to me as a main reason for failing that operation and it's a good reason to give for a user - the operation as a whole failed because there is "No data to move for <VG>" and the reason for that is either that there really is no data to move (no extra message is shown then) or everything has been skipped (in this case we give that extra message). As for giving even more detailed message like why that LV is really skipped - hmm, well, the question is if it's worth adding more complexity in the code just to assemble a more detailed message. Of course, it should be possible to detect that the LV is locked because it is a part of an ongoing pvmove that contains the same LV... But frankly, I wouldn't complicate it since this is a corner case only :) Although I continue to disagree with your "fixed" message, it's not a big enough deal to delay RHEL5.5, so I'll mark it verified and move on... An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2010-0298.html |