Spec URL: http://people.redhat.com/dmalcolm/python/python-sqlparse.spec SRPM URL: http://people.redhat.com/dmalcolm/python/python-sqlparse-0.1.1-1.src.rpm Description: sqlparse is a tool for parsing SQL strings. It can generate pretty-printed renderings of SQL in various formats. It is a python module, together with a command-line tool. Successful scratch build in koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1355440
Builds fine and rpmlint is silent. There seems to be a test suite included in the tarball. Any reason not to run it at build time? * source files match upstream. sha256sum: 6049385a7032628c9a9bc2ac578ce1826e4179b0a8a9f33b535f022fabd8d3ea sqlparse-0.1.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: python-sqlparse = 0.1.1-1.fc11 = /usr/bin/python python(abi) = 2.6 X A test suite is present but not run. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Thanks. I've added a run of the test suite to the %build phase (rather than to the %install as the tests aren't part of the final installed payload; at least, not according to how upstream has written the setup.py) Updated specfile here: http://people.redhat.com/dmalcolm/python/python-sqlparse.spec Updated SRPM here: http://people.redhat.com/dmalcolm/python/python-sqlparse-0.1.1-2.src.rpm Successful scratch build in Koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1395571
Is there some reason the test suite won't run from a %check section? It's rather odd to run it from %build.
Oh, I see the confusion. By "at build time" I meant "when the package is built", not literally "in the %build section". rpm gives us a nice %check section for the purpose of running tests.
Aha! (Clearly I need more coffee/sleep). Thanks. Updated specfile here: http://people.redhat.com/dmalcolm/python/python-sqlparse.spec Updated SRPM here: http://people.redhat.com/dmalcolm/python/python-sqlparse-0.1.1-3.src.rpm Successful scratch build in Koji here: http://koji.fedoraproject.org/koji/taskinfo?taskID=1395636
Looks good; the test suite runs fine: Ran 55 tests in 0.130s OK APPROVED
Thanks New Package CVS Request ======================= Package Name: python-sqlparse Short Description: Non-validating SQL parser for Python Owners: dmalcolm Branches: InitialCC: (i.e. just for devel for now)
CVS done.
Built into devel (f12): http://koji.fedoraproject.org/koji/taskinfo?taskID=1404160 Closing as NEXTRELEASE; thanks!
Package Change Request ====================== Package Name: python-sqlparse New Branches: el6 epel7 Owners: hhorak
Git done (by process-git-requests).