Red Hat Bugzilla – Bug 501116
Review Request: perl-HTML-CalendarMonthSimple - Perl Module for Generating HTML Calendars
Last modified: 2009-11-10 06:23:19 EST
Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-CalendarMonthSimple.spec
SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-HTML-CalendarMonthSimple-1.25-2.fc10.src.rpm
Description: HTML::CalendarMonthSimple is a Perl module for generating, manipulating, and printing a HTML calendar grid for a specified month. It is intended as a faster and easier-to-use alternative to HTML::CalendarMonth.
I'm not sure of the license. Upstream says : " This Perl module is freeware. It may be copied, derived, used, and distributed without limitation." (http://search.cpan.org/~stigmata/HTML-CalendarMonthSimple-1.25/CalendarMonthSimple.pm#AUTHORS,_CREDITS,_COPYRIGHTS). I translated that to Public Domain.
Honestly I don't know if "derived" legally permits modification or not, although it seems pretty obvious to me that's the intent. I don't think it's public domain in any case, because I don't see anything relinquishing copyright. I guess the legal folks can tell us with certainty.
Not public domain, but all the right permissions are there. Mark it as:
License: Copyright only
and we'll be fine here. Lifting FE-Legal.
OK, I'll just pretend the license is changed as above as I review this. Just make the change when you check in.
* source files match upstream. sha256sum:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
perl(HTML::CalendarMonthSimple) = 1.25
perl-HTML-CalendarMonthSimple = 1.25-2.fc11
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
Thanks for the review Tibbs.
New package, fixes the license :
New Package CVS Request
Package Name: perl-HTML-CalendarMonthSimple
Short Description: Perl Module for Generating HTML Calendars
Branches: F-10 F-11 EL-5
Looks like this package already existed and CVS branches exist for it. It's also in rawhide. For some reason, though, it's not in any of the repositories. That would explain why neither of us caught the problem.
I've added the package owner to the CC list for this ticket.
After changing the ownership for the existing branches back, the end result is that you own an EL-5 branch of the package. Generally we want consent of package owner before making EL-5 branches, but it's a bit tough to undo so I hope nobody will mind.
However, we need to figure out why the package has never been pushed. Andreas, if you simply have no interest in this package and want to relinquish is so that Xavier can get it in the distribution, I can take care of that.
After discussion with ixs, I'll take co-maintainership on the package for all the active branches.
Package Change Request
Package Name: perl-HTML-CalendarMonthSimple
Owners: ixs xavierb
Andreas indicated to me in IRC that he should be the owner of the EL-5 branch and that you should be the comaintainer, so that's what I've set up. If you want to be co-maintainer for the rest of the branches, just go to the pkgdb page and add yourself. You don't need to make a CVS request for ownership changes like this.
I had an issue with 'make update' on the EL-5 branch. This seems not to be a general, as I was able to 'make update' in the EL-5 branch for another package.
$ make update
* Wed Jun 03 2009 Xavier Bachelot <email@example.com> 1.25-5
- Change License: to Copyright only.
- Fix README file encoding.
- Preserve timestamp on converted files.
- Remove implicit BR: iconv.
Creating a new update for perl-HTML-CalendarMonthSimple-1.25-5.el5
xavierb does not have commit access to perl-HTML-CalendarMonthSimple
Tibbs, can you take a look ?
Not much I can do. I can verify that you have commit access to the EL-5 branch, but that's about it. Honestly I didn't realize that you even needed to use "make update" for EL branches.
Looks like it might be an issue with bodhi using the 'rawhide' ownership for the EL branches to determine who can push updates. Luke is going to look at it tomorrow and hopefully get it fixed up.
Any reason this is still open?
No particular reason, was just forgotten. thanks for the head up, Jason.