Red Hat Bugzilla – Bug 501260
Users can't log in via squirrelmail
Last modified: 2009-05-21 03:01:32 EDT
After upgrade of squirrelmail to v1.4.18 some people can't log in, the message says Undefined variable: aSpamIds in /usr/share/squirrelmail/plugins/filters/filters.php on line 458 Most likely only those users who has activated their spam filter are concerned, so disabling all spam filters may work as a quick fix: $AllowSpamFilters = false in /usr/share/squirrelmail/plugins/filters/setup.php.
Hi, thanks for reporting this. Could you please check if adding $aSpamIds = array(); on line 418 fixes your problem? Thanks diff -up squirrelmail-1.4.18/plugins/filters/filters.php.orig squirrelmail-1.4.18/plugins/filters/filters.php --- squirrelmail-1.4.18/plugins/filters/filters.php.orig 2009-05-18 12:16:26.628481587 +0200 +++ squirrelmail-1.4.18/plugins/filters/filters.php 2009-05-18 12:16:26.632481429 +0200 @@ -415,7 +415,7 @@ function spam_filters($imap_stream) { $messages = parseFetch($read, $search_array); $bulkquery = (strlen($SpamFilters_BulkQuery) > 0 ? true : false); - + $aSpamIds = array(); foreach($messages as $id=>$message) { if (isset($message['UID'])) { $MsgNum = $message['UID'];
Thank you, your solution works at least for one user. There are no more errors at the browser (in the error_log there are some php notices, they were there before and don't look to be related to this problem). I have to wait for other users to be sure that it works for everybody, but at least it really looks like the right solution. This problem also probably exists in F10+ and rawhide, but the interface does not allow to choose more of distribution versions or being independent.
Thanks for testing, I'll send this patch to upstream. Please let me know if you find this doesn't work for some users.
squirrelmail-1.4.18-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/squirrelmail-1.4.18-2.fc9
squirrelmail-1.4.18-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/squirrelmail-1.4.18-2.fc10
squirrelmail-1.4.18-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/squirrelmail-1.4.18-2.fc11
squirrelmail-1.4.18-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
squirrelmail-1.4.18-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
squirrelmail-1.4.18-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
Your solution works fine, no more undefined variables. But v1.4.18 probably introduced another bug: some users still can't log in, the browser is stalled with blank screen. Last line in the server log is "POST /src/redirect.php HTTP/1.1" 302 I know two possible fixes (not good ones): either $AllowSpamFilters = false or removing user's pref. Setting the spam filters again (by clicking) is possible and the user account works. Unfortunately this behavior cannot be reproduced, nor reduced to minimum configuration, it is not possible in advance to detect users who can't log in.
is anything related in httpd's error log?
There is absolutely nothing related. I've just found another bug of similar type: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=529328 This bug can be reproduced, 14 warnings are both on the screen and log. The related pref is: filters_spam_scan=new
ok, thanks for reporting. There will be new release (1.4.19) from upstream today or tomorrow. You can used this patch meanwhile: http://squirrelmail.svn.sourceforge.net/viewvc/squirrelmail/branches/SM-1_4-STABLE/squirrelmail/plugins/filters/filters.php?r1=13722&r2=13724