Bug 501368 - avc during live install due to leaked fd
Summary: avc during live install due to leaked fd
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rhpl
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F11AnacondaBlocker
TreeView+ depends on / blocked
 
Reported: 2009-05-18 18:56 UTC by Jeremy Katz
Modified: 2009-07-22 15:04 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-07-22 15:04:48 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Jeremy Katz 2009-05-18 18:56:26 UTC
We're leaking an open fd of /dev/mapper/control when we go to exec loadkeys on the live install.

To work around this, we have a few options
a) Figure out where we're opening it and ensure we close /dev/mapper/control
b) Patch libdevice-mapper to open /dev/mapper/control with O_CLOEXEC
c) Patch rhpl to close fds when doing execWith*

c is probably the easiest, but also could have the widest side effects although I don't see how it could break anything off-hand

Comment 1 Chris Lumens 2009-05-19 18:14:56 UTC
While we're digging around in rhpl, we should probably convert the execWith* functions to use subprocess, finally.  Then maybe we could make anaconda use rhpl.executil instead of stuff out of iutil.  Wishful thinking, I know.

Comment 2 Jeremy Katz 2009-05-19 18:26:56 UTC
I'd be more inclined to try to finish killing off rhpl...

Comment 3 Chris Lumens 2009-05-19 19:00:32 UTC
Sure, we can do that too.

Comment 4 James Laska 2009-05-22 17:09:53 UTC
This bug is currently on the F11AnacondaBlocker ... is this a must have for Fedora 11?  Is the  "killing of rhpl" a post-F11 action?

Comment 5 Chris Lumens 2009-05-22 17:17:36 UTC
Choice (c) above is an F11 thing, and killing rhpl is post-F11.  There's more things than just anaconda using it so it's too late to get rid of it.

Comment 6 Jeremy Katz 2009-05-22 18:26:12 UTC
Yeah, killing rhpl is a post-F11 action.

But we should fix the avc as otherwise, people will have it pop up while they're doing installs from the live media (which is at least some high percentage of our install cases) and then file bugs.  We don't want to have to see those bugs for the entire life of F11 :)

Comment 7 Jeremy Katz 2009-05-26 15:36:22 UTC
Simple version of c just for the case that we know we need it sent to anaconda-devel-list for review

Comment 8 Jeremy Katz 2009-05-26 18:56:35 UTC
And built and tag requested

Comment 9 Bug Zapper 2009-06-09 16:04:15 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping


Note You need to log in before you can comment on or make changes to this bug.